README.md

@@ -1,26 +1,39 @@
-# Bank of Maldives CLI written in bash
+# bml-cli
 
-## under dev, lots of things are broken.
+BML CLI written in bash. This project is currently under development, and a lots of things are broken. If possible, pr ascii art lmao.
 
-### can you pr ascii art lmao 
-
-- Requiments 
+## Requirements 
 `curl` `jq`
 
-### known bugs
-- colored texts do not work in termux
+## Bugs
+- Colored texts do not work in Termux
 
+## Installation
+
+### Recommended
 
-### Installation
 ```
-git clone https://github.com/shihaamabr/bmlcli
+git clone https://github.com/shihaamabr/bml-cli
 
-cd bmlcli/
-
-echo "BML_USERNAME=xxxxxxxxx" > .env
-echo "BML_PASSWORD=yyyyyyyyyy" >> .env
+cd bml-cli/
 
 chmod +x bml.sh
 ./bml.sh
+```
+### Not Recommended
 
 ```
+chmod +x install.sh
+./install.sh
+```
+
+## Todo
+
+- [x] Get today's history
+- [x] Get Account details
+- [x] Get contacts
+- [x] Add contacts
+- [x] Delete contacts
+- [ ] Get history from a date range
+- [ ] Make Transfer to a given account number
+- [ ] Make transfers to contact

bml.sh

@@ -51,8 +51,8 @@ if [ "$LOGIN" = "true" ]
 #		curl -s -b $COOKIE $BML_URL/userinfo
 		echo ""
 else
-		#Display error if login was not succuessfull and delete cookie
-                echo "${red}An error occured, Please check Username and Password" 1>&2
+		#Display error if login was not successful and delete cookie
+                echo "${red}An error occurred, Please check Username and Password" 1>&2
                 rm $COOKIE 2> /dev/null
                 exit
 fi
@@ -79,7 +79,7 @@ elif [ "$MENU" = "2" ]
 		echo ""
 		echo "1 - Transfer"
 		echo "2 - Add Contact"
-		echo "3 - Delete Conact"
+		echo "3 - Delete Contact"
 		echo ""
 		printf 'Please Input: '
 		read -r CONTACS

install.sh

@@ -0,0 +1 @@
+curl -sL "https://raw.githubusercontent.com/shihaamabr/bmlcli/main/bml.sh" | sudo tee /usr/bin/bml-cli >/dev/null && sudo chmod 755 /usr/bin/bml-cli