From 7a0e32f4d62bb9348645ee7053a313a22a3c064c Mon Sep 17 00:00:00 2001
From: Shihaam Abdul Rahman <shihaam@shihaam.me>
Date: Thu, 28 May 2026 18:45:57 +0500
Subject: [PATCH] seperate mvr and usd blocked funds in dashboard

---
 .../basedbank/ui/home/DashboardFragment.kt    | 32 ++++-----
 .../main/res/layout/fragment_dashboard.xml    | 68 ++++++++++++++-----
 app/src/main/res/values/strings.xml           |  3 +-
 3 files changed, 68 insertions(+), 35 deletions(-)

diff --git a/app/src/main/java/sh/sar/basedbank/ui/home/DashboardFragment.kt b/app/src/main/java/sh/sar/basedbank/ui/home/DashboardFragment.kt
index ba2d96d..ac020e3 100644
--- a/app/src/main/java/sh/sar/basedbank/ui/home/DashboardFragment.kt
+++ b/app/src/main/java/sh/sar/basedbank/ui/home/DashboardFragment.kt
@@ -278,26 +278,23 @@ class DashboardFragment : Fragment() {
             .groupBy({ it.first }, { it.second })
             .mapValues { (_, vs) -> vs.sum() }
 
+        val blockedMvr = blockedByCurrency["MVR"] ?: 0.0
+        val blockedUsd = blockedByCurrency["USD"] ?: 0.0
         val blockedTotal = blockedByCurrency.values.sum()
-        if (blockedTotal > 0.0) {
-            // Primary line: prefer MVR if present, otherwise the first currency.
-            val primaryCcy = if ("MVR" in blockedByCurrency) "MVR" else blockedByCurrency.keys.first()
-            val primaryAmt = blockedByCurrency.getValue(primaryCcy)
-            binding.tvBlockedTotal.text = if (hide) "$primaryCcy ••••••" else "$primaryCcy %,.2f".format(primaryAmt)
 
-            val secondary = blockedByCurrency.filterKeys { it != primaryCcy }
-            if (secondary.isNotEmpty()) {
-                binding.tvBlockedSecondary.text = secondary.entries.joinToString(" · ") { (ccy, amt) ->
-                    if (hide) "$ccy ••••••" else "$ccy %,.2f".format(amt)
-                }
-                binding.tvBlockedSecondary.visibility = View.VISIBLE
-            } else {
-                binding.tvBlockedSecondary.visibility = View.GONE
-            }
-            binding.cardBlocked.visibility = View.VISIBLE
+        if (blockedMvr > 0.0) {
+            binding.tvBlockedMvr.text = if (hide) "MVR ••••••" else "MVR %,.2f".format(blockedMvr)
+            binding.cardBlockedMvr.visibility = View.VISIBLE
         } else {
-            binding.cardBlocked.visibility = View.GONE
+            binding.cardBlockedMvr.visibility = View.GONE
         }
+        if (blockedUsd > 0.0) {
+            binding.tvBlockedUsd.text = if (hide) "USD ••••••" else "USD %,.2f".format(blockedUsd)
+            binding.cardBlockedUsd.visibility = View.VISIBLE
+        } else {
+            binding.cardBlockedUsd.visibility = View.GONE
+        }
+        binding.rowBlocked.visibility = if (blockedTotal > 0.0) View.VISIBLE else View.GONE
 
         // Overdue: MIB finance deals + BML loan details (assumed MVR — matches existing Pending Finances).
         val mibOverdue = (viewModel.financing.value ?: emptyList()).sumOf { it.overdueAmount }
@@ -310,8 +307,7 @@ class DashboardFragment : Fragment() {
             binding.cardOverdue.visibility = View.GONE
         }
 
-        binding.rowAttention.visibility =
-            if (blockedTotal > 0.0 || overdueTotal > 0.0) View.VISIBLE else View.GONE
+        binding.rowAttention.visibility = if (overdueTotal > 0.0) View.VISIBLE else View.GONE
     }
 
     private fun updatePendingFinances() {
diff --git a/app/src/main/res/layout/fragment_dashboard.xml b/app/src/main/res/layout/fragment_dashboard.xml
index 3fc1b63..1438887 100644
--- a/app/src/main/res/layout/fragment_dashboard.xml
+++ b/app/src/main/res/layout/fragment_dashboard.xml
@@ -176,9 +176,9 @@
 
         </LinearLayout>
 
-        <!-- Attention row: Blocked + Overdue (hidden when nothing applies) -->
+        <!-- Blocked funds row: MVR + USD separate cards (hidden when no blocked amounts) -->
         <LinearLayout
-            android:id="@+id/rowAttention"
+            android:id="@+id/rowBlocked"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:orientation="horizontal"
@@ -186,7 +186,7 @@
             android:visibility="gone">
 
             <com.google.android.material.card.MaterialCardView
-                android:id="@+id/cardBlocked"
+                android:id="@+id/cardBlockedMvr"
                 android:layout_width="0dp"
                 android:layout_height="wrap_content"
                 android:layout_weight="1"
@@ -205,12 +205,12 @@
                     <TextView
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
-                        android:text="@string/dashboard_blocked"
+                        android:text="@string/dashboard_blocked_mvr"
                         android:textAppearance="?attr/textAppearanceLabelSmall"
                         android:textColor="?attr/colorOnErrorContainer" />
 
                     <TextView
-                        android:id="@+id/tvBlockedTotal"
+                        android:id="@+id/tvBlockedMvr"
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
                         android:layout_marginTop="4dp"
@@ -218,22 +218,12 @@
                         android:textAppearance="?attr/textAppearanceTitleMedium"
                         android:textColor="?attr/colorOnErrorContainer" />
 
-                    <TextView
-                        android:id="@+id/tvBlockedSecondary"
-                        android:layout_width="wrap_content"
-                        android:layout_height="wrap_content"
-                        android:layout_marginTop="2dp"
-                        android:textAppearance="?attr/textAppearanceLabelSmall"
-                        android:textColor="?attr/colorOnErrorContainer"
-                        android:alpha="0.75"
-                        android:visibility="gone" />
-
                 </LinearLayout>
 
             </com.google.android.material.card.MaterialCardView>
 
             <com.google.android.material.card.MaterialCardView
-                android:id="@+id/cardOverdue"
+                android:id="@+id/cardBlockedUsd"
                 android:layout_width="0dp"
                 android:layout_height="wrap_content"
                 android:layout_weight="1"
@@ -241,6 +231,52 @@
                 app:cardElevation="1dp"
                 app:cardCornerRadius="12dp"
                 app:cardBackgroundColor="?attr/colorErrorContainer"
+                android:visibility="gone">
+
+                <LinearLayout
+                    android:layout_width="match_parent"
+                    android:layout_height="wrap_content"
+                    android:orientation="vertical"
+                    android:padding="16dp">
+
+                    <TextView
+                        android:layout_width="wrap_content"
+                        android:layout_height="wrap_content"
+                        android:text="@string/dashboard_blocked_usd"
+                        android:textAppearance="?attr/textAppearanceLabelSmall"
+                        android:textColor="?attr/colorOnErrorContainer" />
+
+                    <TextView
+                        android:id="@+id/tvBlockedUsd"
+                        android:layout_width="wrap_content"
+                        android:layout_height="wrap_content"
+                        android:layout_marginTop="4dp"
+                        android:text="USD —"
+                        android:textAppearance="?attr/textAppearanceTitleMedium"
+                        android:textColor="?attr/colorOnErrorContainer" />
+
+                </LinearLayout>
+
+            </com.google.android.material.card.MaterialCardView>
+
+        </LinearLayout>
+
+        <!-- Overdue row (hidden when no overdue financing) -->
+        <LinearLayout
+            android:id="@+id/rowAttention"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:orientation="horizontal"
+            android:layout_marginTop="16dp"
+            android:visibility="gone">
+
+            <com.google.android.material.card.MaterialCardView
+                android:id="@+id/cardOverdue"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                app:cardElevation="1dp"
+                app:cardCornerRadius="12dp"
+                app:cardBackgroundColor="?attr/colorErrorContainer"
                 android:clickable="true"
                 android:focusable="true"
                 android:visibility="gone">
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 0c5de6d..878b4d0 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -218,7 +218,8 @@
     <string name="cards">Cards</string>
     <string name="available_balance">Available Balance</string>
     <string name="account_blocked_label">%1$s blocked</string>
-    <string name="dashboard_blocked">Blocked Funds</string>
+    <string name="dashboard_blocked_mvr">Blocked MVR</string>
+    <string name="dashboard_blocked_usd">Blocked USD</string>
     <string name="dashboard_overdue">Overdue Financing</string>
 
     <!-- Transfer -->