diff --git a/app/src/main/java/sh/sar/basedbank/ui/home/AccountHistoryFragment.kt b/app/src/main/java/sh/sar/basedbank/ui/home/AccountHistoryFragment.kt index 2d4232d..64ed377 100644 --- a/app/src/main/java/sh/sar/basedbank/ui/home/AccountHistoryFragment.kt +++ b/app/src/main/java/sh/sar/basedbank/ui/home/AccountHistoryFragment.kt @@ -142,6 +142,8 @@ class AccountHistoryFragment : Fragment() { } adapter.setTransactions(filtered) binding.emptyView.visibility = if (filtered.isEmpty() && !isLoading) View.VISIBLE else View.GONE + binding.skeletonContainer.visibility = + if (allTransactions.isEmpty() && isLoading) View.VISIBLE else View.GONE } private fun resetAndReload() { @@ -168,6 +170,9 @@ class AccountHistoryFragment : Fragment() { if (firstPageDone && allTransactions.isNotEmpty()) { adapter.showLoadingFooter = true + } else if (allTransactions.isEmpty()) { + binding.skeletonContainer.visibility = View.VISIBLE + binding.emptyView.visibility = View.GONE } val app = requireActivity().application as BasedBankApp @@ -187,6 +192,7 @@ class AccountHistoryFragment : Fragment() { isLoading = false if (_binding == null) return@launch + binding.skeletonContainer.visibility = View.GONE if (!firstPageDone) { firstPageDone = true diff --git a/app/src/main/java/sh/sar/basedbank/ui/home/ContactsFragment.kt b/app/src/main/java/sh/sar/basedbank/ui/home/ContactsFragment.kt index fb0897a..e013690 100644 --- a/app/src/main/java/sh/sar/basedbank/ui/home/ContactsFragment.kt +++ b/app/src/main/java/sh/sar/basedbank/ui/home/ContactsFragment.kt @@ -9,6 +9,7 @@ import android.view.View import android.view.ViewGroup import android.widget.Toast import com.google.android.material.dialog.MaterialAlertDialogBuilder +import com.google.android.material.snackbar.Snackbar import androidx.core.view.ViewCompat import androidx.core.view.WindowInsetsCompat import androidx.core.widget.addTextChangedListener @@ -194,10 +195,10 @@ class ContactsFragment : Fragment() { viewLifecycleOwner.lifecycleScope.launch { val success = withContext(Dispatchers.IO) { ContactManager.delete(contact, app) } if (success) { - Toast.makeText(requireContext(), R.string.contact_deleted, Toast.LENGTH_SHORT).show() removeFromViewModel(contact) + Snackbar.make(binding.root, R.string.contact_deleted, Snackbar.LENGTH_SHORT).show() } else { - Toast.makeText(requireContext(), R.string.contact_delete_failed, Toast.LENGTH_SHORT).show() + Snackbar.make(binding.root, R.string.contact_delete_failed, Snackbar.LENGTH_LONG).show() } } } diff --git a/app/src/main/java/sh/sar/basedbank/ui/home/TransferHistoryFragment.kt b/app/src/main/java/sh/sar/basedbank/ui/home/TransferHistoryFragment.kt index 82bac28..0a8d9f1 100644 --- a/app/src/main/java/sh/sar/basedbank/ui/home/TransferHistoryFragment.kt +++ b/app/src/main/java/sh/sar/basedbank/ui/home/TransferHistoryFragment.kt @@ -181,6 +181,9 @@ class TransferHistoryFragment : Fragment() { if (firstBatchDone && allTransactions.isNotEmpty()) { adapter.showLoadingFooter = true + } else if (allTransactions.isEmpty()) { + binding.skeletonContainer.visibility = View.VISIBLE + binding.emptyView.visibility = View.GONE } val app = requireActivity().application as BasedBankApp @@ -286,6 +289,7 @@ class TransferHistoryFragment : Fragment() { isLoading = false if (_binding == null) return@launch + binding.skeletonContainer.visibility = View.GONE val raw = bannerMsg.get() when { @@ -329,6 +333,8 @@ class TransferHistoryFragment : Fragment() { } adapter.setTransactions(filtered) binding.emptyView.visibility = if (filtered.isEmpty() && !isLoading) View.VISIBLE else View.GONE + binding.skeletonContainer.visibility = + if (allTransactions.isEmpty() && isLoading) View.VISIBLE else View.GONE } private fun loadContactImage(name: String) { diff --git a/app/src/main/res/layout/activity_home.xml b/app/src/main/res/layout/activity_home.xml index 3b76046..dbbb6b3 100644 --- a/app/src/main/res/layout/activity_home.xml +++ b/app/src/main/res/layout/activity_home.xml @@ -44,8 +44,8 @@ android:id="@+id/connectivityBanner" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="#C62828" - android:textColor="#FFFFFF" + android:background="?attr/colorErrorContainer" + android:textColor="?attr/colorOnErrorContainer" android:gravity="center" android:paddingTop="6dp" android:paddingBottom="6dp" diff --git a/app/src/main/res/layout/fragment_account_history.xml b/app/src/main/res/layout/fragment_account_history.xml index 6e823cf..c368fa3 100644 --- a/app/src/main/res/layout/fragment_account_history.xml +++ b/app/src/main/res/layout/fragment_account_history.xml @@ -48,6 +48,22 @@ android:paddingBottom="16dp" android:clipToPadding="false" /> + + + + + + + + + + + + + + + + + + + + + + @@ -49,7 +50,8 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:textAppearance="?attr/textAppearanceBodySmall" - android:textColor="?attr/colorOnSurface" /> + android:textColor="?attr/colorOnSurface" + android:fontFeatureSettings="tnum" /> diff --git a/app/src/main/res/layout/item_more_nav.xml b/app/src/main/res/layout/item_more_nav.xml index 3d9db65..cc19c1c 100644 --- a/app/src/main/res/layout/item_more_nav.xml +++ b/app/src/main/res/layout/item_more_nav.xml @@ -13,7 +13,8 @@ android:id="@+id/ivIcon" android:layout_width="24dp" android:layout_height="24dp" - android:layout_marginEnd="16dp" /> + android:layout_marginEnd="16dp" + android:importantForAccessibility="no" /> + android:layout_marginBottom="6dp" + android:importantForAccessibility="no" />