refactor: fix missing await and bad practices

.env

@@ -1,5 +0,0 @@
-PORT = 8080
-PGUSER=alok-pg
-PGHOST=localhost
-PGDATABASE=okiba
-PGPORT=5432

.gitignore

@@ -1,5 +1,5 @@
+.env
 node_modules/
 public/
 test/
 data/
-.env

src/db/bin.ts

@@ -8,12 +8,7 @@ export const getAvailableWord = async (db: Pool): Promise<Word | undefined> => {
         .query(Query.getAvailableWord)
         .catch((err) => err);
 
-    if (data != undefined) {
+    return data?.rows[0];
-        let word = data.rows[0];
-        return word;
-    }
-
-    return undefined;
 };
 
 export const setWordTaken = async (db: Pool, id: number) => {

src/main.ts

@@ -4,34 +4,39 @@ import BinRouter from "./routes/bin";
 import { Client, Pool } from "pg";
 import { createDataDir, errorHandler, logError, logSuccess } from "./utils";
 
-dotenv.config();
+const main = async () => {
-createDataDir();
+    dotenv.config();
+    createDataDir();
 
-// init db
+    // init db
-const pool = new Pool();
+    const pool = await new Pool();
-const client = new Client();
+    const client = await new Client();
 
-client
+    client
         .connect()
         .then(() => {
             logSuccess("Connected to database!");
         })
         .catch((err: Error) => {
             logError(`Could not connect to database! \n\n${err.message}`);
+            throw err;
         });
 
-// start server
+    // start server
-const app: Express = express();
+    const app: Express = express();
-const port = process.env.PORT;
+    const port = process.env.PORT;
 
-app.use(express.text());
+    app.use(express.text());
 
-app.get("/", (req: Request, res: Response) => {
+    app.get("/", (req: Request, res: Response) => {
         res.send("Hello, World!");
-});
+    });
-app.use("/bin/", BinRouter(pool));
+    app.use("/bin/", BinRouter(pool));
 
-app.use(errorHandler);
+    app.use(errorHandler);
-app.listen(port, () => {
+    app.listen(port, () => {
         logSuccess(`Server started on port ${port}`);
-});
+    });
+};
+
+main();

src/routes/bin.ts

@@ -11,6 +11,9 @@ export default function BinRouter(db: Pool) {
 
     router.post("/paste", async (req: Request, res: Response) => {
         let body: string = req.body;
+        if (body == undefined || body == "") {
+            return res.status(400).json({ message: "Invalid body!" });
+        }
 
         const word: Word | undefined = await getAvailableWord(db);
 
@@ -21,8 +24,8 @@ export default function BinRouter(db: Pool) {
                 (err) => err
             );
 
-            setWordTaken(db, word.id);
+            await setWordTaken(db, word.id);
-            console.log(word.id);
+
             return res.status(200).json({
                 endpoint: word.val,
                 message: "Code pasted successfully!",