From f6f58d3c99c7048f16818b385e5fbc252ebb9ccc Mon Sep 17 00:00:00 2001
From: Shihaam Abdul Rahman <shihaam@shihaam.me>
Date: Sat, 11 Feb 2023 01:29:15 +0500
Subject: [PATCH] code improvement

---
 scrap.sh | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/scrap.sh b/scrap.sh
index 41ef3915..50f39419 100755
--- a/scrap.sh
+++ b/scrap.sh
@@ -2,7 +2,7 @@
 START_NID=$1
 END_NID=$2
 FILENAME=A${1}-A${2}.json
-while true;
+while [ "$START_NID" -le "$END_NID" ];
 do
   echo Scraping: $START_NID
   CONTENT=$(curl -si https://fikureggedhirun.com/api/fetch?nic=A$START_NID > .cache)
@@ -19,9 +19,4 @@ do
 	 	echo delaying
 	 	sleep 1000
 	fi
-
-	if [ "$END_NID" = "$START_NID" ]
-	then
-		exit 1
-	fi
 done