From 44d2ac2019cb61116fed1ff231d4d89784e93fe5 Mon Sep 17 00:00:00 2001
From: Shihaam Abdul Rahman <shihaam@shihaam.me>
Date: Wed, 15 Nov 2023 20:04:40 +0500
Subject: [PATCH] a better port scan

---
 scripts/port-scan | 22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

diff --git a/scripts/port-scan b/scripts/port-scan
index 6691a3a..ff3c6cc 100755
--- a/scripts/port-scan
+++ b/scripts/port-scan
@@ -1,9 +1,23 @@
 #!/bin/bash
 
-for port in {20..10000}
+# Check if two arguments are provided
+if [ "$#" -ne 2 ]; then
+    echo "Usage: $0 <hostname or ip> <port-range>"
+    exit 1
+fi
+
+hostname=$1
+port_range=$2
+
+# Split the port range into start and end
+IFS='-' read -ra PORTS <<< "$port_range"
+start_port=${PORTS[0]}
+end_port=${PORTS[1]}
+
+# Iterate over the port range
+for ((port=start_port; port<=end_port; port++))
 do
-
-(echo > /dev/tcp/$1/$port) &>/dev/null && echo Port $port open
-
+    (echo > /dev/tcp/$hostname/$port) &>/dev/null && echo "Port $port open"
 done
 
+exit 0