added model check to api show endpoints

app/Http/Controllers/Api/Auth/Users.php

@@ -40,6 +40,10 @@ class Users extends ApiController
             $user = User::with('companies', 'permissions', 'roles')->where('email', $id)->first();
         }
 
+        if (! $user instanceof User) {
+            return $this->errorInternal('No query results for model [' . User::class . '] ' . $id);
+        }
+
         return new Resource($user);
     }
 

app/Http/Controllers/Api/Banking/Accounts.php

@@ -39,6 +39,10 @@ class Accounts extends ApiController
             $account = Account::where('number', $id)->first();
         }
 
+        if (! $account instanceof Account) {
+            return $this->errorInternal('No query results for model [' . Account::class . '] ' . $id);
+        }
+
         return new Resource($account);
     }
 

app/Http/Controllers/Api/Common/Contacts.php

@@ -42,6 +42,11 @@ class Contacts extends ApiController
             $contact = Contact::where('email', $id)->first();
         }
 
+        if (! $contact instanceof Contact) {
+            //return $this->noContent();
+            return $this->errorInternal('No query results for model [' . Contact::class . '] ' . $id);
+        }
+
         return new Resource($contact);
     }
 

app/Http/Controllers/Api/Common/Dashboards.php

@@ -39,6 +39,10 @@ class Dashboards extends ApiController
         try {
             $dashboard = Dashboard::with('widgets')->find($id);
 
+            if (! $dashboard instanceof Dashboard) {
+                return $this->errorInternal('No query results for model [' . Dashboard::class . '] ' . $id);
+            }
+
             // Check if user can access dashboard
             $this->canAccess($dashboard);
 

app/Http/Controllers/Api/Common/Items.php

@@ -34,6 +34,10 @@ class Items extends ApiController
     {
         $item = Item::with('category', 'taxes')->find($id);
 
+        if (! $item instanceof Item) {
+            return $this->errorInternal('No query results for model [' . Item::class . '] ' . $id);
+        }
+
         return new Resource($item);
     }
 

app/Http/Controllers/Api/Document/DocumentTransactions.php

@@ -48,6 +48,10 @@ class DocumentTransactions extends ApiController
     {
         $transaction = Transaction::documentId($document_id)->find($id);
 
+        if (! $transaction instanceof Transaction) {
+            return $this->errorInternal('No query results for model [' . Transaction::class . '] ' . $id);
+        }
+
         return new Resource($transaction);
     }
 

app/Http/Controllers/Api/Document/Documents.php

@@ -39,6 +39,10 @@ class Documents extends ApiController
             $document = Document::where('document_number', $id)->first();
         }
 
+        if (! $document instanceof Document) {
+            return $this->errorInternal('No query results for model [' . Document::class . '] ' . $id);
+        }
+
         return new Resource($document);
     }
 

app/Http/Controllers/Api/Settings/Currencies.php

@@ -39,6 +39,10 @@ class Currencies extends ApiController
             $currency = Currency::where('code', $id)->first();
         }
 
+        if (! $currency instanceof Currency) {
+            return $this->errorInternal('No query results for model [' . Currency::class . '] ' . $id);
+        }
+
         return new Resource($currency);
     }
 

app/Http/Controllers/Api/Settings/Settings.php

@@ -47,6 +47,10 @@ class Settings extends ApiController
             $setting = Setting::where('key', $id)->first();
         }
 
+        if (! $setting instanceof Setting) {
+            return $this->errorInternal('No query results for model [' . Setting::class . '] ' . $id);
+        }
+
         return new Resource($setting);
     }