From ebfc67709a5102295392a8494441fb71f86dbf47 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Denis=20Duli=C3=A7i?= Date: Thu, 21 Jul 2022 16:36:34 +0300 Subject: [PATCH] formatting --- app/Abstracts/Report.php | 7 ++----- app/Models/Setting/Category.php | 11 ++++++++++- app/Traits/Charts.php | 7 ------- app/Widgets/ExpensesByCategory.php | 2 +- 4 files changed, 13 insertions(+), 14 deletions(-) diff --git a/app/Abstracts/Report.php b/app/Abstracts/Report.php index 070dd5a6d..5b8366569 100644 --- a/app/Abstracts/Report.php +++ b/app/Abstracts/Report.php @@ -17,7 +17,6 @@ use App\Models\Setting\Category; use App\Traits\Charts; use App\Traits\DateTime; use App\Traits\SearchString; -use App\Traits\Tailwind; use App\Traits\Translations; use App\Utilities\Date; use App\Utilities\Export as ExportHelper; @@ -25,7 +24,7 @@ use Illuminate\Support\Str; abstract class Report { - use Charts, DateTime, SearchString, Tailwind, Translations; + use Charts, DateTime, SearchString, Translations; public $model; @@ -236,9 +235,7 @@ abstract class Report foreach ($tmp_values as $id => $value) { $labels[$id] = $this->row_names[$table_key][$id]; - $color = ($group == 'category') ? Category::withSubCategory()->find($id)?->color : '#' . dechex(rand(0x000000, 0xFFFFFF)); - - $colors[$id] = $this->getHexCodeOfTailwindClass($color); + $colors[$id] = ($group == 'category') ? Category::withSubCategory()->find($id)?->colorHexCode : '#' . dechex(rand(0x000000, 0xFFFFFF)); $values[$id] = round(($value * 100 / $total), 0); } diff --git a/app/Models/Setting/Category.php b/app/Models/Setting/Category.php index b899e534a..826717051 100644 --- a/app/Models/Setting/Category.php +++ b/app/Models/Setting/Category.php @@ -8,6 +8,7 @@ use App\Models\Document\Document; use App\Relations\HasMany\Category as HasMany; use App\Scopes\Category as Scope; use App\Traits\Categories; +use App\Traits\Tailwind; use App\Traits\Transactions; use Illuminate\Database\Eloquent\Builder as EloquentBuilder; use Illuminate\Database\Eloquent\Factories\HasFactory; @@ -15,7 +16,7 @@ use Illuminate\Database\Eloquent\Model as EloquentModel; class Category extends Model { - use Categories, HasFactory, Transactions; + use Categories, HasFactory, Tailwind, Transactions; public const INCOME_TYPE = 'income'; public const EXPENSE_TYPE = 'expense'; @@ -217,6 +218,14 @@ class Category extends Model return $query->withoutGlobalScope(new Scope); } + /** + * Get the hex code of the color. + */ + public function getColorHexCodeAttribute(): string + { + return $this->getHexCodeOfTailwindClass($this->color); + } + /** * Get the line actions. * diff --git a/app/Traits/Charts.php b/app/Traits/Charts.php index 6167514fc..be223e77f 100644 --- a/app/Traits/Charts.php +++ b/app/Traits/Charts.php @@ -3,13 +3,10 @@ namespace App\Traits; use Akaunting\Apexcharts\Chart; -use App\Traits\Tailwind; use Balping\JsonRaw\Raw; trait Charts { - use Tailwind; - public $bar = [ 'colors' => [], 'labels' => [], @@ -37,8 +34,6 @@ trait Charts $label .= ' - ' . $description; } - $color = $this->getHexCodeOfTailwindClass($color); - $this->addToDonut($color, $label, $amount); } @@ -74,8 +69,6 @@ trait Charts public function addToBar($color, $label, $value) { - $color = $this->getHexCodeOfTailwindClass($color); - $this->bar['colors'][] = $color; $this->bar['labels'][] = $label; $this->bar['values'][] = (int) $value; diff --git a/app/Widgets/ExpensesByCategory.php b/app/Widgets/ExpensesByCategory.php index f135ce799..e1e88860d 100644 --- a/app/Widgets/ExpensesByCategory.php +++ b/app/Widgets/ExpensesByCategory.php @@ -22,7 +22,7 @@ class ExpensesByCategory extends Widget $amount += $transaction->getAmountConvertedToDefault(); }); - $this->addMoneyToDonut($category->color, $amount, $category->name); + $this->addMoneyToDonut($category->colorHexCode, $amount, $category->name); }); $chart = $this->getDonutChart(trans_choice('general.expenses', 2), '100%', 300, 6);