optimization

This commit is contained in:
denisdulici 2017-12-06 13:42:30 +03:00
parent 137a319700
commit 9aab36c2dc

View File

@ -19,7 +19,7 @@ class Currencies extends Controller
{ {
$currencies = Currency::collect(); $currencies = Currency::collect();
return view('settings.currencies.index', compact('currencies', 'codes', 'rates')); return view('settings.currencies.index', compact('currencies'));
} }
/** /**
@ -116,20 +116,23 @@ class Currencies extends Controller
*/ */
public function update(Currency $currency, Request $request) public function update(Currency $currency, Request $request)
{ {
$relationships = $this->countRelationships($currency, [ // Check if we can disable it
'accounts' => 'accounts', if (!$request['enabled']) {
'customers' => 'customers', $relationships = $this->countRelationships($currency, [
'invoices' => 'invoices', 'accounts' => 'accounts',
'revenues' => 'revenues', 'customers' => 'customers',
'bills' => 'bills', 'invoices' => 'invoices',
'payments' => 'payments', 'revenues' => 'revenues',
]); 'bills' => 'bills',
'payments' => 'payments',
]);
if ($currency->code == setting('general.default_currency')) { if ($currency->code == setting('general.default_currency')) {
$relationships[] = strtolower(trans_choice('general.companies', 1)); $relationships[] = strtolower(trans_choice('general.companies', 1));
}
} }
if (empty($relationships) || $request['enabled']) { if (empty($relationships)) {
// Force the rate to be 1 for default currency // Force the rate to be 1 for default currency
if ($request['default_currency']) { if ($request['default_currency']) {
$request['rate'] = '1'; $request['rate'] = '1';