shihaam/akaunting
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

close #1448 Fixed: Missing pagination for app reviews

Browse Source
This commit is contained in:
Cüneyt Şentürk
2020-05-19 20:06:20 +03:00
parent a69ea5b3c5
commit 771df1047a
6 changed files with 112 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/Http/Controllers/Modules/Item.php
View File

@ -269,11 +269,9 @@ class Item extends Controller
public function reviews($alias, Request $request)
{
$page = $request['page'];
$data = [
'query' => [
'page' => ($page) ? $page : 1,
'page' => $request->get('page', 1),
]
];
@ -284,7 +282,7 @@ class Item extends Controller
return response()->json([
'success' => true,
'error' => false,
'data' => null,
'data' => $reviews,
'message' => null,
'html' => $html,
]);

6
app/Traits/Modules.php
View File

@ -77,8 +77,10 @@ trait Modules
public function getModuleReviews($alias, $data = [])
{
$page = isset($data['query']['page']) ? $data['query']['page'] : 1;
// Get data from cache
$reviews = Cache::get('apps.' . $alias . '.reviews');
$reviews = Cache::get('apps.' . $alias . '.reviews'. $page);
if (!empty($reviews)) {
return $reviews;
@ -86,7 +88,7 @@ trait Modules
$reviews = static::getResponseData('GET', 'apps/' . $alias . '/reviews', $data);
Cache::put('apps.' . $alias . '.reviews', $reviews, Date::now()->addHour());
Cache::put('apps.' . $alias . '.reviews' . $page, $reviews, Date::now()->addHour());
return $reviews;
}