From 466a81cdba31b3967ae53350f2ba4b273cda38ec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Denis=20Duli=C3=A7i?= <denisdulici@gmail.com>
Date: Thu, 4 Jun 2020 19:18:29 +0300
Subject: [PATCH] prevent duplicating document transactions

---
 app/Models/Banking/Transaction.php                 |  5 +++++
 resources/views/purchases/payments/index.blade.php | 10 ++++++----
 resources/views/sales/revenues/index.blade.php     | 10 ++++++----
 3 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/app/Models/Banking/Transaction.php b/app/Models/Banking/Transaction.php
index f82e36f86..e4f3e7a87 100644
--- a/app/Models/Banking/Transaction.php
+++ b/app/Models/Banking/Transaction.php
@@ -218,6 +218,11 @@ class Transaction extends Model
         return $query->where('reconciled', 0);
     }
 
+    public function onCloning($src, $child = null)
+    {
+        $this->document_id = null;
+    }
+
     /**
      * Convert amount to double.
      *
diff --git a/resources/views/purchases/payments/index.blade.php b/resources/views/purchases/payments/index.blade.php
index d9fc743cc..3174ae345 100644
--- a/resources/views/purchases/payments/index.blade.php
+++ b/resources/views/purchases/payments/index.blade.php
@@ -92,15 +92,17 @@
                                                 <a class="dropdown-item" href="{{ route('payments.edit', $item->id) }}">{{ trans('general.edit') }}</a>
                                                 <div class="dropdown-divider"></div>
                                             @endif
+                                            @if (empty($item->document_id))
                                             @permission('create-purchases-payments')
                                                 <a class="dropdown-item" href="{{ route('payments.duplicate', $item->id) }}">{{ trans('general.duplicate') }}</a>
+                                                <div class="dropdown-divider"></div>
                                             @endpermission
+                                            @endif
+                                            @if (!$item->reconciled)
                                             @permission('delete-purchases-payments')
-                                                @if (!$item->reconciled)
-                                                    <div class="dropdown-divider"></div>
-                                                    {!! Form::deleteLink($item, 'payments.destroy') !!}
-                                                @endif
+                                                {!! Form::deleteLink($item, 'payments.destroy') !!}
                                             @endpermission
+                                            @endif
                                         </div>
                                     </div>
                                 </td>
diff --git a/resources/views/sales/revenues/index.blade.php b/resources/views/sales/revenues/index.blade.php
index 9fb2e7aff..d19f501e1 100644
--- a/resources/views/sales/revenues/index.blade.php
+++ b/resources/views/sales/revenues/index.blade.php
@@ -92,15 +92,17 @@
                                                 <a class="dropdown-item" href="{{ route('revenues.edit', $item->id) }}">{{ trans('general.edit') }}</a>
                                                 <div class="dropdown-divider"></div>
                                             @endif
+                                            @if (empty($item->document_id))
                                             @permission('create-sales-revenues')
                                                 <a class="dropdown-item" href="{{ route('revenues.duplicate', $item->id) }}">{{ trans('general.duplicate') }}</a>
+                                                <div class="dropdown-divider"></div>
                                             @endpermission
+                                            @endif
+                                            @if (!$item->reconciled)
                                             @permission('delete-sales-revenues')
-                                                @if (!$item->reconciled)
-                                                    <div class="dropdown-divider"></div>
-                                                    {!! Form::deleteLink($item, 'revenues.destroy') !!}
-                                                @endif
+                                                {!! Form::deleteLink($item, 'revenues.destroy') !!}
                                             @endpermission
+                                            @endif
                                         </div>
                                     </div>
                                 </td>