From 44c16e9a09fb8929ce181d7fc3fe793aa74c640a Mon Sep 17 00:00:00 2001
From: batuhanbas <b1atuhanb1as@gmail.com>
Date: Tue, 31 Dec 2019 17:36:07 +0300
Subject: [PATCH] code review for js files

---
 resources/assets/js/views/auth/permissions.js        | 2 ++
 resources/assets/js/views/auth/users.js              | 2 ++
 resources/assets/js/views/banking/accounts.js        | 3 +++
 resources/assets/js/views/banking/reconciliations.js | 2 ++
 resources/assets/js/views/banking/transactions.js    | 2 ++
 resources/assets/js/views/banking/transfers.js       | 2 ++
 resources/assets/js/views/common/companies.js        | 2 ++
 resources/assets/js/views/common/reports.js          | 2 ++
 resources/assets/js/views/common/search.js           | 1 +
 resources/assets/js/views/purchases/bills.js         | 1 +
 resources/assets/js/views/purchases/payments.js      | 2 ++
 resources/assets/js/views/purchases/vendors.js       | 2 ++
 resources/assets/js/views/sales/invoices.js          | 1 +
 resources/assets/js/views/settings/currencies.js     | 3 +++
 resources/assets/js/views/settings/taxes.js          | 3 +++
 15 files changed, 30 insertions(+)

diff --git a/resources/assets/js/views/auth/permissions.js b/resources/assets/js/views/auth/permissions.js
index 33248550d..073f7eedd 100644
--- a/resources/assets/js/views/auth/permissions.js
+++ b/resources/assets/js/views/auth/permissions.js
@@ -15,9 +15,11 @@ import BulkAction from './../../plugins/bulk-action';
 
 const app = new Vue({
     el: '#app',
+
     mixins: [
         Global
     ],
+
     data: function () {
         return {
             form: new Form('permission'),
diff --git a/resources/assets/js/views/auth/users.js b/resources/assets/js/views/auth/users.js
index 46c60df89..d53549e9a 100644
--- a/resources/assets/js/views/auth/users.js
+++ b/resources/assets/js/views/auth/users.js
@@ -15,9 +15,11 @@ import BulkAction from './../../plugins/bulk-action';
 
 const app = new Vue({
     el: '#app',
+
     mixins: [
         Global
     ],
+
     data: function () {
         return {
             form: new Form('user'),
diff --git a/resources/assets/js/views/banking/accounts.js b/resources/assets/js/views/banking/accounts.js
index 9ab89d840..e78993db5 100644
--- a/resources/assets/js/views/banking/accounts.js
+++ b/resources/assets/js/views/banking/accounts.js
@@ -15,15 +15,18 @@ import BulkAction from './../../plugins/bulk-action';
 
 const app = new Vue({
     el: '#app',
+
     mixins: [
         Global
     ],
+
     data: function () {
         return {
             form: new Form('account'),
             bulk_action: new BulkAction('accounts')
         }
     },
+
     methods:{
         onChangeCurrency(currency_code) {
             axios.get(url + '/settings/currencies/currency', {
diff --git a/resources/assets/js/views/banking/reconciliations.js b/resources/assets/js/views/banking/reconciliations.js
index 72f66613a..22c59699a 100644
--- a/resources/assets/js/views/banking/reconciliations.js
+++ b/resources/assets/js/views/banking/reconciliations.js
@@ -15,9 +15,11 @@ import BulkAction from './../../plugins/bulk-action';
 
 const app = new Vue({
     el: '#app',
+
     mixins: [
         Global
     ],
+
     data: function () {
         return {
             form: new Form('reconciliation'),
diff --git a/resources/assets/js/views/banking/transactions.js b/resources/assets/js/views/banking/transactions.js
index b7d3b16f5..d179fe64c 100644
--- a/resources/assets/js/views/banking/transactions.js
+++ b/resources/assets/js/views/banking/transactions.js
@@ -15,9 +15,11 @@ import BulkAction from './../../plugins/bulk-action';
 
 const app = new Vue({
     el: '#app',
+
     mixins: [
         Global
     ],
+
     data: function () {
         return {
         }
diff --git a/resources/assets/js/views/banking/transfers.js b/resources/assets/js/views/banking/transfers.js
index b3b7e5268..0a2e6b4ad 100644
--- a/resources/assets/js/views/banking/transfers.js
+++ b/resources/assets/js/views/banking/transfers.js
@@ -15,9 +15,11 @@ import BulkAction from './../../plugins/bulk-action';
 
 const app = new Vue({
     el: '#app',
+
     mixins: [
         Global
     ],
+
     data: function () {
         return {
             form: new Form('transfer'),
diff --git a/resources/assets/js/views/common/companies.js b/resources/assets/js/views/common/companies.js
index 2d65cff2b..d622e8910 100644
--- a/resources/assets/js/views/common/companies.js
+++ b/resources/assets/js/views/common/companies.js
@@ -15,9 +15,11 @@ import BulkAction from './../../plugins/bulk-action';
 
 const app = new Vue({
     el: '#app',
+
     mixins: [
         Global
     ],
+
     data: function () {
         return {
             form: new Form('company'),
diff --git a/resources/assets/js/views/common/reports.js b/resources/assets/js/views/common/reports.js
index 6ce1e3b97..944591c6a 100644
--- a/resources/assets/js/views/common/reports.js
+++ b/resources/assets/js/views/common/reports.js
@@ -15,9 +15,11 @@ import BulkAction from './../../plugins/bulk-action';
 
 const app = new Vue({
     el: '#app',
+
     mixins: [
         Global
     ],
+
     data: function () {
         return {
             form: new Form('report'),
diff --git a/resources/assets/js/views/common/search.js b/resources/assets/js/views/common/search.js
index 55f8f84ee..d9e80c3b5 100644
--- a/resources/assets/js/views/common/search.js
+++ b/resources/assets/js/views/common/search.js
@@ -20,6 +20,7 @@ Vue.directive('click-outside', clickOutside);
 
 const search = new Vue({
     el: '#global-search',
+
     data: function () {
         return {
             show: false,
diff --git a/resources/assets/js/views/purchases/bills.js b/resources/assets/js/views/purchases/bills.js
index 8b3b94314..3732a2bfb 100644
--- a/resources/assets/js/views/purchases/bills.js
+++ b/resources/assets/js/views/purchases/bills.js
@@ -16,6 +16,7 @@ import BulkAction from './../../plugins/bulk-action';
 
 const app = new Vue({
     el: '#app',
+
     mixins: [
         Global
     ],
diff --git a/resources/assets/js/views/purchases/payments.js b/resources/assets/js/views/purchases/payments.js
index 36f18fd77..511182900 100644
--- a/resources/assets/js/views/purchases/payments.js
+++ b/resources/assets/js/views/purchases/payments.js
@@ -15,9 +15,11 @@ import BulkAction from './../../plugins/bulk-action';
 
 const app = new Vue({
     el: '#app',
+
     mixins: [
         Global
     ],
+
     data: function () {
         return {
             form: new Form('payment'),
diff --git a/resources/assets/js/views/purchases/vendors.js b/resources/assets/js/views/purchases/vendors.js
index 24c923be3..2117b1ef9 100644
--- a/resources/assets/js/views/purchases/vendors.js
+++ b/resources/assets/js/views/purchases/vendors.js
@@ -15,9 +15,11 @@ import BulkAction from './../../plugins/bulk-action';
 
 const app = new Vue({
     el: '#app',
+
     mixins: [
         Global
     ],
+
     data: function () {
         return {
             form: new Form('vendor'),
diff --git a/resources/assets/js/views/sales/invoices.js b/resources/assets/js/views/sales/invoices.js
index 7d8edb372..a57f7b2c8 100644
--- a/resources/assets/js/views/sales/invoices.js
+++ b/resources/assets/js/views/sales/invoices.js
@@ -16,6 +16,7 @@ import BulkAction from './../../plugins/bulk-action';
 
 const app = new Vue({
     el: '#app',
+
     mixins: [
         Global
     ],
diff --git a/resources/assets/js/views/settings/currencies.js b/resources/assets/js/views/settings/currencies.js
index 2311ae0ac..f3d463430 100644
--- a/resources/assets/js/views/settings/currencies.js
+++ b/resources/assets/js/views/settings/currencies.js
@@ -15,15 +15,18 @@ import BulkAction from './../../plugins/bulk-action';
 
 const app = new Vue({
     el: '#app',
+
     mixins: [
         Global
     ],
+
     data: function () {
         return {
             form: new Form('currency'),
             bulk_action: new BulkAction('currencies')
         }
     },
+
     methods:{
         RateReplace(){
             this.form.rate = this.form.rate.replace(',', '.');
diff --git a/resources/assets/js/views/settings/taxes.js b/resources/assets/js/views/settings/taxes.js
index 475383060..df4913358 100644
--- a/resources/assets/js/views/settings/taxes.js
+++ b/resources/assets/js/views/settings/taxes.js
@@ -15,15 +15,18 @@ import BulkAction from './../../plugins/bulk-action';
 
 const app = new Vue({
     el: '#app',
+
     mixins: [
         Global
     ],
+
     data: function () {
         return {
             form: new Form('tax'),
             bulk_action: new BulkAction('taxes')
         }
     },
+
     methods:{
         taxRateReplace(){
             this.form.rate = this.form.rate.replace(',', '.');