diff --git a/app/Abstracts/Listeners/Report.php b/app/Abstracts/Listeners/Report.php index 90af9521a..676e3c07f 100644 --- a/app/Abstracts/Listeners/Report.php +++ b/app/Abstracts/Listeners/Report.php @@ -114,11 +114,11 @@ abstract class Report public function applyAccountGroup($event) { - if (($event->model->getTable() != 'invoices') && ($event->model->getTable() != 'bills')) { + if ($event->model->getTable() != 'documents') { return; } - $filter = request('accounts', []); + $filter = explode(',', $this->getSearchStringValue('account_id')); $event->model->account_id = 0; diff --git a/app/Listeners/Report/AddAccounts.php b/app/Listeners/Report/AddAccounts.php index a048889ed..fbaf8c0f1 100644 --- a/app/Listeners/Report/AddAccounts.php +++ b/app/Listeners/Report/AddAccounts.php @@ -74,7 +74,9 @@ class AddAccounts extends Listener return; } - if ($accounts = request('accounts')) { + if ($account_ids = $this->getSearchStringValue('account_id')) { + $accounts = explode(',', $account_ids); + $rows = collect($event->class->filters['accounts'])->filter(function ($value, $key) use ($accounts) { return in_array($key, $accounts); }); diff --git a/app/Listeners/Report/AddCustomers.php b/app/Listeners/Report/AddCustomers.php index 698b25026..b208c8f17 100644 --- a/app/Listeners/Report/AddCustomers.php +++ b/app/Listeners/Report/AddCustomers.php @@ -73,7 +73,9 @@ class AddCustomers extends Listener return; } - if ($customers = request('customers')) { + if ($customer_ids = $this->getSearchStringValue('customer_id')) { + $customers = explode(',', $customer_ids); + $rows = collect($event->class->filters['customers'])->filter(function ($value, $key) use ($customers) { return in_array($key, $customers); }); diff --git a/app/Listeners/Report/AddExpenseCategories.php b/app/Listeners/Report/AddExpenseCategories.php index 73d04b65d..fef703fc3 100644 --- a/app/Listeners/Report/AddExpenseCategories.php +++ b/app/Listeners/Report/AddExpenseCategories.php @@ -56,7 +56,9 @@ class AddExpenseCategories extends Listener return; } - if ($categories = request('categories')) { + if ($category_ids = $this->getSearchStringValue('category_id')) { + $categories = explode(',', $category_ids); + $rows = collect($event->class->filters['categories'])->filter(function ($value, $key) use ($categories) { return in_array($key, $categories); }); diff --git a/app/Listeners/Report/AddIncomeCategories.php b/app/Listeners/Report/AddIncomeCategories.php index b0f160829..f725b94ed 100644 --- a/app/Listeners/Report/AddIncomeCategories.php +++ b/app/Listeners/Report/AddIncomeCategories.php @@ -56,7 +56,9 @@ class AddIncomeCategories extends Listener return; } - if ($categories = request('categories')) { + if ($category_ids = $this->getSearchStringValue('category_id')) { + $categories = explode(',', $category_ids); + $rows = collect($event->class->filters['categories'])->filter(function ($value, $key) use ($categories) { return in_array($key, $categories); }); diff --git a/app/Listeners/Report/AddIncomeExpenseCategories.php b/app/Listeners/Report/AddIncomeExpenseCategories.php index 7555eda64..183dc3789 100644 --- a/app/Listeners/Report/AddIncomeExpenseCategories.php +++ b/app/Listeners/Report/AddIncomeExpenseCategories.php @@ -75,7 +75,9 @@ class AddIncomeExpenseCategories extends Listener break; case 'App\Reports\IncomeExpenseSummary': - if ($categories = request('categories')) { + if ($category_ids = $this->getSearchStringValue('category_id')) { + $categories = explode(',', $category_ids); + $rows = collect($event->class->filters['categories'])->filter(function ($value, $key) use ($categories) { return in_array($key, $categories); }); diff --git a/app/Listeners/Report/AddSearch.php b/app/Listeners/Report/AddSearchString.php similarity index 61% rename from app/Listeners/Report/AddSearch.php rename to app/Listeners/Report/AddSearchString.php index 8fb4df09b..8bce21bdc 100644 --- a/app/Listeners/Report/AddSearch.php +++ b/app/Listeners/Report/AddSearchString.php @@ -4,9 +4,8 @@ namespace App\Listeners\Report; use App\Abstracts\Listeners\Report as Listener; use App\Events\Report\FilterApplying; -use App\Events\Report\FilterShowing; -class AddSearch extends Listener +class AddSearchString extends Listener { protected $classes = [ 'App\Reports\IncomeSummary', @@ -16,21 +15,6 @@ class AddSearch extends Listener 'App\Reports\TaxSummary', ]; - /** - * Handle filter showing event. - * - * @param $event - * @return void - */ - public function handleFilterShowing(FilterShowing $event) - { - if ($this->skipThisClass($event)) { - return; - } - - //$event->class->filters['search'] = $this->getSearch(); - } - /** * Handle filter applying event. * @@ -43,7 +27,7 @@ class AddSearch extends Listener return; } - // Apply date + // Apply search string $this->applySearchStringFilter($event); } } diff --git a/app/Listeners/Report/AddVendors.php b/app/Listeners/Report/AddVendors.php index 66f3beb07..696b4c2eb 100644 --- a/app/Listeners/Report/AddVendors.php +++ b/app/Listeners/Report/AddVendors.php @@ -73,7 +73,9 @@ class AddVendors extends Listener return; } - if ($vendors = request('vendors')) { + if ($vendor_ids = $this->getSearchStringValue('vendor_id')) { + $vendors = explode(',', $vendor_ids); + $rows = collect($event->class->filters['vendors'])->filter(function ($value, $key) use ($vendors) { return in_array($key, $vendors); }); diff --git a/app/Providers/Event.php b/app/Providers/Event.php index fea9f3e2c..61979b159 100644 --- a/app/Providers/Event.php +++ b/app/Providers/Event.php @@ -92,7 +92,7 @@ class Event extends Provider 'App\Listeners\Report\AddExpenseCategories', 'App\Listeners\Report\AddIncomeCategories', 'App\Listeners\Report\AddIncomeExpenseCategories', - 'App\Listeners\Report\AddSearch', + 'App\Listeners\Report\AddSearchString', 'App\Listeners\Report\AddRowsToTax', ]; } diff --git a/config/search-string.php b/config/search-string.php index 42a65d852..b0bb646f6 100644 --- a/config/search-string.php +++ b/config/search-string.php @@ -13,7 +13,7 @@ return [ | */ - 'fail' => 'no-results', + 'fail' => 'all-results', /* |--------------------------------------------------------------------------