fixed tests

This commit is contained in:
denisdulici
2019-11-18 10:54:26 +03:00
parent 63ab57730d
commit 2cdc431f8c
17 changed files with 123 additions and 154 deletions

View File

@ -119,7 +119,7 @@ class UsersTest extends FeatureTestCase
'password_confirmation' => $password,
'locale' => 'en-GB',
'companies' => [$this->company->id],
'roles' => Role::take(1)->pluck('id')->toArray(),
'roles' => ['1'],
'enabled' => $this->faker->boolean ? 1 : 0,
];
}

View File

@ -3,7 +3,6 @@
namespace Tests\Feature\Banking;
use App\Jobs\Banking\CreateAccount;
use App\Models\Banking\Account;
use Tests\Feature\FeatureTestCase;
class AccountsTest extends FeatureTestCase
@ -47,7 +46,7 @@ class AccountsTest extends FeatureTestCase
{
$request = $this->getAccountRequest();
$account= Account::create($request);
$account = $this->dispatch(new CreateAccount($request));
$request['name'] = $this->faker->text(5);
@ -60,7 +59,7 @@ class AccountsTest extends FeatureTestCase
public function testItShouldDeleteAccount()
{
$account = Account::create($this->getAccountRequest());
$account = $this->dispatch(new CreateAccount($this->getAccountRequest()));
$this->loginAs()
->delete(route('accounts.destroy', ['account' => $account]))
@ -74,13 +73,13 @@ class AccountsTest extends FeatureTestCase
return [
'company_id' => $this->company->id,
'name' => $this->faker->text(5),
'number' => '1',
'currency_code' => setting('default.currency'),
'opening_balance' => 0,
'number' => (string) $this->faker->randomNumber(2),
'currency_code' => setting('default.currency', 'USD'),
'opening_balance' => '0',
'bank_name' => $this->faker->text(5),
'bank_phone' => null,
'bank_address' => null,
'default_account' => $this->faker->randomElement(['yes', 'no']),
'default_account' => 0,
'enabled' => $this->faker->boolean ? 1 : 0,
];
}

View File

@ -68,7 +68,6 @@ class ReconciliationsTest extends FeatureTestCase
$this->assertFlashLevel('success');
}
private function getReconciliationRequest()
{
return [

View File

@ -3,7 +3,7 @@
namespace Tests\Feature\Banking;
use App\Jobs\Banking\CreateTransaction;
use App\Jobs\Banking\CreateTransfer;
use App\Models\Banking\Transfer;
use Illuminate\Http\UploadedFile;
use Tests\Feature\FeatureTestCase;
@ -27,11 +27,9 @@ class TransfersTest extends FeatureTestCase
public function testItShouldCreateTransfer()
{
// Create income
$income_transaction = $this->dispatch(new CreateTransaction($this->getIncomeRequest()));
$income_transaction = $this->dispatch(new CreateTransaction($this->getTransactionRequest('income')));
// Create expense
$expense_transaction = $this->dispatch(new CreateTransaction($this->getExpenseRequest()));
$expense_transaction = $this->dispatch(new CreateTransaction($this->getTransactionRequest('expense')));
$this->loginAs()
->post(route('transfers.store'), $this->getTransferRequest($income_transaction, $expense_transaction))
@ -42,31 +40,27 @@ class TransfersTest extends FeatureTestCase
public function testItShouldSeeTransferUpdatePage()
{
// Create income
$income_transaction = $this->dispatch(new CreateTransaction($this->getIncomeRequest()));
$income_transaction = $this->dispatch(new CreateTransaction($this->getTransactionRequest('income')));
// Create expense
$expense_transaction = $this->dispatch(new CreateTransaction($this->getExpenseRequest()));
$expense_transaction = $this->dispatch(new CreateTransaction($this->getTransactionRequest('expense')));
$transfer = $this->dispatch(new CreateTransfer($this->getTransferRequest($income_transaction, $expense_transaction)));
$transfer = Transfer::create($this->getTransferRequest($income_transaction, $expense_transaction));
$this->loginAs()
->get(route('transfers.edit', ['transfer' => $transfer->id]))
->assertStatus(200)
->assertSee($expense_transaction->description);
->assertSee($transfer->description);
}
public function testItShouldUpdateTransfer()
{
// Create income
$income_transaction = $this->dispatch(new CreateTransaction($this->getIncomeRequest()));
$income_transaction = $this->dispatch(new CreateTransaction($this->getTransactionRequest('income')));
// Create expense
$expense_transaction = $this->dispatch(new CreateTransaction($this->getExpenseRequest()));
$expense_transaction = $this->dispatch(new CreateTransaction($this->getTransactionRequest('expense')));
$request = $this->getTransferRequest($income_transaction, $expense_transaction);
$transfer = $this->dispatch(new CreateTransfer($request));
$transfer = Transfer::create($request);
$request['description'] = $this->faker->text(10);
@ -79,13 +73,11 @@ class TransfersTest extends FeatureTestCase
public function testItShouldDeleteTransfer()
{
// Create income
$income_transaction = $this->dispatch(new CreateTransaction($this->getIncomeRequest()));
$income_transaction = $this->dispatch(new CreateTransaction($this->getTransactionRequest('income')));
// Create expense
$expense_transaction = $this->dispatch(new CreateTransaction($this->getExpenseRequest()));
$expense_transaction = $this->dispatch(new CreateTransaction($this->getTransactionRequest('expense')));
$transfer = $this->dispatch(new CreateTransfer($this->getTransferRequest($income_transaction, $expense_transaction)));
$transfer = Transfer::create($this->getTransferRequest($income_transaction, $expense_transaction));
$this->loginAs()
->delete(route('transfers.destroy', ['transfer' => $transfer->id]))
@ -112,43 +104,23 @@ class TransfersTest extends FeatureTestCase
];
}
private function getIncomeRequest()
private function getTransactionRequest($type)
{
$attachment = UploadedFile::fake()->create('image.jpg');
return [
'company_id' => $this->company->id,
'type' => 'income',
'type' => $type,
'account_id' => setting('default.account'),
'paid_at' => $this->faker->date(),
'amount' => $this->faker->randomFloat(2, 2),
'currency_code' => setting('default.currency'),
'currency_rate' => '1',
'description' => $this->faker->text(5),
'category_id' => $this->company->categories()->type('income')->first()->id,
'category_id' => $this->company->categories()->type($type)->first()->id,
'reference' => $this->faker->text(5),
'payment_method' => setting('default.payment_method'),
'attachment' => $attachment
];
}
private function getExpenseRequest()
{
$attachment = UploadedFile::fake()->create('image.jpg');
return [
'company_id' => $this->company->id,
'type' => 'expense',
'account_id' => setting('default.account'),
'paid_at' => $this->faker->date(),
'amount' => $this->faker->randomFloat(2, 2),
'currency_code' => setting('default.currency'),
'currency_rate' => '1',
'description' => $this->faker->text(5),
'category_id' => $this->company->categories()->type('expense')->first()->id,
'payment_method' => setting('default.payment_method'),
'reference' => $this->faker->text(5),
'attachment' => $attachment
'attachment' => $attachment,
];
}
}

View File

@ -4,19 +4,19 @@ namespace Tests\Feature\Commands;
use App\Jobs\Expense\CreateBill;
use App\Notifications\Expense\Bill as BillNotification;
use Illuminate\Support\Facades\Notification;
use Illuminate\Support\Facades\Notification as Notification;
use Jenssegers\Date\Date;
use Tests\Feature\FeatureTestCase;
class BillReminderTest extends FeatureTestCase
{
private $addDay;
private $add_days;
protected function setUp(): void
{
parent::setUp();
$this->addDay = 3;
$this->add_days = 3;
}
public function testBillReminderByDueDate()
@ -25,7 +25,7 @@ class BillReminderTest extends FeatureTestCase
$bill = $this->dispatch(new CreateBill($this->getBillRequest()));
Date::setTestNow(Date::now()->subDays($this->addDay));
Date::setTestNow(Date::now()->subDays($this->add_days));
$this->artisan('reminder:bill');
@ -41,7 +41,6 @@ class BillReminderTest extends FeatureTestCase
/**
* Bill request
*
* @param int $recurring
* @return array
*/
private function getBillRequest()
@ -50,27 +49,27 @@ class BillReminderTest extends FeatureTestCase
$items = [['name' => $this->faker->text(5), 'item_id' => null, 'quantity' => '1', 'price' => $amount, 'currency' => 'USD']];
$data = [
'contact_id' => '0',
$data = [
'company_id' => $this->company->id,
'billed_at' => $this->faker->date(),
'due_at' => Date::now()->subDays($this->addDay - 1),
'due_at' => Date::now()->subDays($this->add_days - 1),
'bill_number' => '1',
'order_number' => '1',
'currency_code' => setting('default.currency'),
'currency_code' => setting('default.currency', 'USD'),
'currency_rate' => '1',
'items' => $items,
'discount' => '0',
'notes' => $this->faker->text(5),
'category_id' => $this->company->categories()->type('income')->first()->id,
'category_id' => $this->company->categories()->type('expense')->pluck('id')->first(),
'recurring_frequency' => 'no',
'contact_name' => $this->faker->name,
'contact_email' => $this->faker->email,
'contact_id' => '0',
'contact_name' => $this->faker->name,
'contact_email' =>$this->faker->email,
'contact_tax_number' => null,
'contact_phone' => null,
'contact_address' => $this->faker->address,
'bill_status_code' => 'sent',
'contact_phone' => null,
'contact_address' => $this->faker->address,
'bill_status_code' => 'received',
'amount' => $amount,
'company_id' => $this->company->id,
];
return $data;

View File

@ -10,13 +10,13 @@ use Tests\Feature\FeatureTestCase;
class InvoiceReminderTest extends FeatureTestCase
{
private $addDay;
private $add_days;
protected function setUp(): void
{
parent::setUp();
$this->addDay = 3;
$this->add_days = 3;
}
public function testInvoiceReminderByDueDate()
@ -25,7 +25,7 @@ class InvoiceReminderTest extends FeatureTestCase
$invoice = $this->dispatch(new CreateInvoice($this->getInvoiceRequest()));
Date::setTestNow(Date::now()->addDay($this->addDay));
Date::setTestNow(Date::now()->addDay($this->add_days));
$this->artisan('reminder:invoice');
@ -50,26 +50,26 @@ class InvoiceReminderTest extends FeatureTestCase
$items = [['name' => $this->faker->text(5), 'item_id' => null, 'quantity' => '1', 'price' => $amount, 'currency' => 'USD']];
$data = [
'contact_id' => '0',
'company_id' => $this->company->id,
'invoiced_at' => $this->faker->date(),
'due_at' => Date::now()->addDay($this->addDay - 1),
'due_at' => Date::now()->subDays($this->add_days - 1),
'invoice_number' => '1',
'order_number' => '1',
'currency_code' => setting('default.currency'),
'order_number' => '1',
'currency_code' => setting('default.currency', 'USD'),
'currency_rate' => '1',
'items' => $items,
'discount' => '0',
'notes' => $this->faker->text(5),
'category_id' => $this->company->categories()->type('income')->first()->id,
'category_id' => $this->company->categories()->type('income')->pluck('id')->first(),
'recurring_frequency' => 'no',
'contact_name' => $this->faker->name,
'contact_email' => $this->faker->email,
'contact_id' => '0',
'contact_name' => $this->faker->name,
'contact_email' =>$this->faker->email,
'contact_tax_number' => null,
'contact_phone' => null,
'contact_address' => $this->faker->address,
'contact_phone' => null,
'contact_address' => $this->faker->address,
'invoice_status_code' => 'sent',
'amount' => $amount,
'company_id' => $this->company->id,
];
return $data;

View File

@ -49,7 +49,7 @@ class ItemsTest extends FeatureTestCase
$item = $this->dispatch(new CreateItem($request));
$request['name'] = $this->faker->text(15);
$request['name'] = $this->faker->text(15);
$this->loginAs()
->patch(route('items.update', $item->id), $request)

View File

@ -90,7 +90,7 @@ class BillsTest extends FeatureTestCase
'due_at' => $this->faker->date(),
'bill_number' => '1',
'order_number' => '1',
'currency_code' => setting('default.currency'),
'currency_code' => setting('default.currency', 'USD'),
'currency_rate' => '1',
'items' => $items,
'discount' => '0',

View File

@ -9,15 +9,10 @@ use Tests\TestCase;
abstract class FeatureTestCase extends TestCase
{
/**
* @var \Faker\Generator
*/
protected $faker;
/** @var User */
protected $user;
/** @var Company */
protected $company;
protected function setUp(): void

View File

@ -49,17 +49,6 @@ class CustomersTest extends FeatureTestCase
$this->assertEquals($customer['email'], $user->email);
}
public function testItShouldNotCreateCustomerWithExistsUser()
{
$customer = $this->getCustomerRequestWithUser();
User::create($customer);
$this->loginAs()
->post(route('customers.store'), $customer)
->assertSessionHasErrors(['email']);
}
public function testItShouldSeeCustomerDetailPage()
{
$customer = $this->dispatch(new CreateContact($this->getCustomerRequest()));

View File

@ -90,7 +90,7 @@ class InvoicesTest extends FeatureTestCase
'due_at' => $this->faker->date(),
'invoice_number' => '1',
'order_number' => '1',
'currency_code' => setting('default.currency'),
'currency_code' => setting('default.currency', 'USD'),
'currency_rate' => '1',
'items' => $items,
'discount' => '0',