From 935c53a5d9f6955acd42b1b30320d78ccf41ce0e Mon Sep 17 00:00:00 2001
From: "benguozakinci@gmail.com"
 <akaunting-002@Akaunting-002s-MacBook-Pro.local>
Date: Tue, 27 Jul 2021 10:06:56 +0300
Subject: [PATCH 1/4] Add prop for limiting character by default

---
 resources/views/components/select-item-button.blade.php | 1 +
 1 file changed, 1 insertion(+)

diff --git a/resources/views/components/select-item-button.blade.php b/resources/views/components/select-item-button.blade.php
index 57ef2fc60..ffe81aa3e 100644
--- a/resources/views/components/select-item-button.blade.php
+++ b/resources/views/components/select-item-button.blade.php
@@ -6,6 +6,7 @@
     price="{{ $price }}"
     :dynamic-currency="currency"
     :items="{{ json_encode($items) }}"
+    :search-char-limit="3"
     @item="onSelectedItem($event)"
     add-item-text="{{ trans('general.form.add_an', ['field' => trans_choice('general.items', 1)]) }}"
     create-new-item-text="{{ trans('general.title.create', ['type' =>  trans_choice('general.items', 1)]) }}"

From d363b111f20f8364aaf2feba28a8f800e5997882 Mon Sep 17 00:00:00 2001
From: "benguozakinci@gmail.com"
 <akaunting-002@Akaunting-002s-MacBook-Pro.local>
Date: Tue, 27 Jul 2021 10:25:40 +0300
Subject: [PATCH 2/4] Use given default char limit to fetch data

---
 .../js/components/AkauntingItemButton.vue     | 44 ++++++++++++-------
 1 file changed, 28 insertions(+), 16 deletions(-)

diff --git a/resources/assets/js/components/AkauntingItemButton.vue b/resources/assets/js/components/AkauntingItemButton.vue
index 792c9eb5f..49cd10b57 100644
--- a/resources/assets/js/components/AkauntingItemButton.vue
+++ b/resources/assets/js/components/AkauntingItemButton.vue
@@ -33,7 +33,7 @@
                 </div>
 
                 <ul class="aka-select-menu-options">
-                    <div class="aka-select-menu-option" v-for="(item, index) in sortItems" :key="index" @click="onItemSeleted(index, item.id)">
+                    <div class="aka-select-menu-option" v-for="(item, index) in sortedItems" :key="index" @click="onItemSeleted(index, item.id)">
                         <div class="item-select w-100">
                             <div class="item-select-column item-select-info w-75">
                                 <b class="item-select-info-name"><span>{{ item.name }}</span></b>
@@ -52,7 +52,7 @@
                         </div>
                     </div>
 
-                    <div class="aka-select-menu-option" v-if="!sortItems.length">
+                    <div class="aka-select-menu-option" v-if="!sortedItems.length">
                         <div>
                             <strong class="text-strong" v-if="!items.length && !search">
                                 <span>{{ noDataText }}</span>
@@ -128,7 +128,6 @@ export default {
             default: () => [],
             description: 'List of Items'
         },
-
         addNew: {
             type: Object,
             default: function () {
@@ -187,18 +186,22 @@ export default {
             },
             description: "Default currency"
         },
+        searchCharLimit: {
+            type: Number,
+            default: 3,
+            description: "Character limit for item search input"
+        }
     },
 
     data() {
         return {
             item_list: [],
             selected_items: [],
-            search: '', // search cloumn model
+            search: '', // search coLumn model
             show: {
                 item_selected: false,
                 item_list: false,
             },
-
             form: {},
             add_new: {
                 text: this.addNew.text,
@@ -266,7 +269,11 @@ export default {
         },
 
         onInput() {
-            if (!this.search) {
+           if (this.search.length < this.searchCharLimit) {
+                this.setItemList(this.items);
+                this.sortItems();
+                this.$emit('input', this.search);
+
                 return;
             }
 
@@ -496,13 +503,6 @@ export default {
                 this.setItemList(this.items);
             }
         },
-    },
-
-    created() {
-        this.setItemList(this.items);
-    },
-
-    computed: {
         sortItems() {
             this.item_list.sort(function (a, b) {
                 var nameA = a.value.toUpperCase(); // ignore upper and lowercase
@@ -520,9 +520,21 @@ export default {
                 return 0;
             });
 
-            return this.item_list.filter(item => {
-                return item.value.toLowerCase().includes(this.search.toLowerCase())
-            });
+            const sortedItemList = this.item_list.filter(item => 
+                item.value.toLowerCase().includes(this.search.toLowerCase())
+            );
+
+            return sortedItemList;
+        },
+    },
+
+    created() {
+        this.setItemList(this.items);
+    },
+
+    computed: {
+        sortedItems() {
+            return this.sortItems();
         },
     },
 

From a28dd087def0896817f54b4c6453bcfbc7fd9cb3 Mon Sep 17 00:00:00 2001
From: "benguozakinci@gmail.com"
 <akaunting-002@Akaunting-002s-MacBook-Pro.local>
Date: Tue, 27 Jul 2021 11:06:18 +0300
Subject: [PATCH 3/4] Check if the input is empty before sorting and filterin
 options

---
 .../js/components/AkauntingItemButton.vue       | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/resources/assets/js/components/AkauntingItemButton.vue b/resources/assets/js/components/AkauntingItemButton.vue
index 49cd10b57..574a1544b 100644
--- a/resources/assets/js/components/AkauntingItemButton.vue
+++ b/resources/assets/js/components/AkauntingItemButton.vue
@@ -197,7 +197,7 @@ export default {
         return {
             item_list: [],
             selected_items: [],
-            search: '', // search coLumn model
+            search: '', // search column model
             show: {
                 item_selected: false,
                 item_list: false,
@@ -269,13 +269,18 @@ export default {
         },
 
         onInput() {
-           if (this.search.length < this.searchCharLimit) {
-                this.setItemList(this.items);
-                this.sortItems();
-                this.$emit('input', this.search);
-
+            //to optimize performance we kept the condition that checks for if search exists or not
+            if (!this.search) {
                 return;
             }
+            //condition that checks if input is below the given character limit 
+            if (this.search.length < this.searchCharLimit) {
+                    this.setItemList(this.items); //once the user deletes the search input, we show the overall item list
+                    this.sortItems(); // we order it as wanted
+                    this.$emit('input', this.search); // keep the input binded to v-model
+
+                    return;
+            }
 
             window.axios.get(url + '/common/items?search="' + this.search + '" limit:10')
             .then(response => {

From 1df7c8e87f8958f087ced2df4a6d15d5ac7799dd Mon Sep 17 00:00:00 2001
From: "benguozakinci@gmail.com"
 <akaunting-002@Akaunting-002s-MacBook-Pro.local>
Date: Tue, 27 Jul 2021 17:56:35 +0300
Subject: [PATCH 4/4] Integrate back-end for default value

---
 .../View/Components/DocumentForm.php          | 27 ++++++++++++++++++-
 app/View/Components/SelectItemButton.php      |  6 ++++-
 config/setting.php                            |  2 ++
 .../documents/form/content.blade.php          |  1 +
 .../components/documents/form/items.blade.php |  1 +
 .../components/documents/form/main.blade.php  |  1 +
 .../components/select-item-button.blade.php   |  2 +-
 7 files changed, 37 insertions(+), 3 deletions(-)

diff --git a/app/Abstracts/View/Components/DocumentForm.php b/app/Abstracts/View/Components/DocumentForm.php
index fa1bfcd56..fb8337d6e 100644
--- a/app/Abstracts/View/Components/DocumentForm.php
+++ b/app/Abstracts/View/Components/DocumentForm.php
@@ -207,6 +207,9 @@ abstract class DocumentForm extends Base
 
     /** @var bool */
     public $isPurchasePrice;
+
+    /** @var int */
+    public $searchCharLimit;
     /** Items Component End */
 
     /**
@@ -240,7 +243,7 @@ abstract class DocumentForm extends Base
         bool $hideItems = false, bool $hideName = false, bool $hideDescription = false, bool $hideQuantity = false,
         bool $hidePrice = false, bool $hideDiscount = false, bool $hideAmount = false,
         bool $hideEditItemColumns = false,
-        bool $isSalePrice = false, bool $isPurchasePrice = false
+        bool $isSalePrice = false, bool $isPurchasePrice = false, int $searchCharLimit = 0
         /** Items Component End */
     ) {
         $this->type = $type;
@@ -325,6 +328,7 @@ abstract class DocumentForm extends Base
         $this->hideEditItemColumns = $hideEditItemColumns;
         $this->isSalePrice = $isSalePrice;
         $this->isPurchasePrice = $isPurchasePrice;
+        $this->searchCharLimit = $this->getSearchCharLimit($type, $searchCharLimit);
         /** Items Component End */
     }
 
@@ -1020,4 +1024,25 @@ abstract class DocumentForm extends Base
 
         return setting($this->getSettingKey($this->type, 'notes'));
     }
+
+    protected function getSearchCharLimit($type, $searchCharLimit)
+    {
+        if (!empty($searchCharLimit)) {
+            return $searchCharLimit;
+        }
+
+        // if you use settting translation
+        if ($settingCharLimit = setting($this->getSettingKey($type, 'item_search_chart_limit'), false)) {
+            return $settingCharLimit;
+        }
+
+        $hide = $this->getHideFromConfig($type, 'item_search_char_limit');
+
+        if ($hide) {
+            return $hide;
+        }
+
+        // @todo what return value invoice or always false??
+        return setting('invoice.item_search_char_limit', $searchCharLimit);
+    }
 }
diff --git a/app/View/Components/SelectItemButton.php b/app/View/Components/SelectItemButton.php
index ae1008d96..720f54412 100644
--- a/app/View/Components/SelectItemButton.php
+++ b/app/View/Components/SelectItemButton.php
@@ -16,16 +16,20 @@ class SelectItemButton extends Component
     /** @var bool */
     public $isPurchase;
 
+    /** @var int */
+    public $searchCharLimit;
+
     /**
      * Create a new component instance.
      *
      * @return void
      */
-    public function __construct(string $type = 'sale', bool $isSale = false, bool $isPurchase = false)
+    public function __construct(string $type = 'sale', bool $isSale = false, bool $isPurchase = false, int $searchCharLimit = 3)
     {
         $this->type = $type;
         $this->isSale = $isSale;
         $this->isPurchase = $isPurchase;
+        $this->searchCharLimit = $searchCharLimit;
     }
 
     /**
diff --git a/config/setting.php b/config/setting.php
index 114be521d..937957947 100644
--- a/config/setting.php
+++ b/config/setting.php
@@ -122,6 +122,7 @@ return [
             'color'                     => env('SETTING_FALLBACK_INVOICE_COLOR', '#55588b'),
             'logo_size_width'           => env('SETTING_FALLBACK_INVOICE_LOGO_SIZE_WIDTH', 128),
             'logo_size_height'          => env('SETTING_FALLBACK_INVOICE_LOGO_SIZE_HEIGHT', 128),
+            'item_search_char_limit'    => env('SETTING_FALLBACK_INVOICE_ITEM_SEARCH_CHAR_LIMIT', 3),
         ],
         'bill' => [
             'number_prefix'             => env('SETTING_FALLBACK_BILL_NUMBER_PREFIX', 'BILL-'),
@@ -133,6 +134,7 @@ return [
             'payment_terms'             => env('SETTING_FALLBACK_BILL_PAYMENT_TERMS', '0'),
             'template'                  => env('SETTING_FALLBACK_BILL_TEMPLATE', 'default'),
             'color'                     => env('SETTING_FALLBACK_BILL_COLOR', '#55588b'),
+            'item_search_char_limit'    => env('SETTING_FALLBACK_BILL_ITEM_SEARCH_CHAR_LIMIT', 3),
         ],
         'default' => [
             'currency'                  => env('SETTING_FALLBACK_DEFAULT_CURRENCY', 'USD'),
diff --git a/resources/views/components/documents/form/content.blade.php b/resources/views/components/documents/form/content.blade.php
index 1def1e9ec..207e8c2b0 100644
--- a/resources/views/components/documents/form/content.blade.php
+++ b/resources/views/components/documents/form/content.blade.php
@@ -68,6 +68,7 @@
             text-amount="{{ $textAmount }}"
             is-sale-price="{{ $isSalePrice }}"
             is-purchase-price="{{ $isPurchasePrice }}"
+            search-char-limit="{{ $searchCharLimit }}"
             notes-setting="{{ $notesSetting }}"
         />
 
diff --git a/resources/views/components/documents/form/items.blade.php b/resources/views/components/documents/form/items.blade.php
index 486b2db8f..955d3a81d 100644
--- a/resources/views/components/documents/form/items.blade.php
+++ b/resources/views/components/documents/form/items.blade.php
@@ -77,6 +77,7 @@
                                     type="{{ $type }}"
                                     is-sale="{{ $isSalePrice }}"
                                     is-purchase="{{ $isPurchasePrice }}"
+                                    search-char-limit="{{ $searchCharLimit }}"
                                 />
                             </td>
                         </tr>
diff --git a/resources/views/components/documents/form/main.blade.php b/resources/views/components/documents/form/main.blade.php
index 684722cc9..919ff877e 100644
--- a/resources/views/components/documents/form/main.blade.php
+++ b/resources/views/components/documents/form/main.blade.php
@@ -44,6 +44,7 @@
             text-amount="{{ $textAmount }}"
             is-sale-price="{{ $isSalePrice }}"
             is-purchase-price="{{ $isPurchasePrice }}"
+            search-char-limit="{{ $searchCharLimit }}"
         />
 
         <x-documents.form.totals
diff --git a/resources/views/components/select-item-button.blade.php b/resources/views/components/select-item-button.blade.php
index ffe81aa3e..f4855e6d3 100644
--- a/resources/views/components/select-item-button.blade.php
+++ b/resources/views/components/select-item-button.blade.php
@@ -6,7 +6,7 @@
     price="{{ $price }}"
     :dynamic-currency="currency"
     :items="{{ json_encode($items) }}"
-    :search-char-limit="3"
+    :search-char-limit="{{ $searchCharLimit }}"
     @item="onSelectedItem($event)"
     add-item-text="{{ trans('general.form.add_an', ['field' => trans_choice('general.items', 1)]) }}"
     create-new-item-text="{{ trans('general.title.create', ['type' =>  trans_choice('general.items', 1)]) }}"