more improvements

app/Http/Controllers/Auth/Users.php

@@ -21,7 +21,7 @@ class Users extends Controller
         $users = User::with('roles')->collect();
 
         $roles = collect(Role::all()->pluck('display_name', 'id'))
-            ->prepend(trans('roles.all'), '');
+            ->prepend(trans('general.all_type', ['type' => trans_choice('general.roles', 2)]), '');
 
         return view('auth.users.index', compact('users', 'roles'));
     }

app/Http/Controllers/Banking/Transfers.php

@@ -27,7 +27,7 @@ class Transfers extends Controller
         $items = Transfer::with(['payment', 'revenue', 'account'])->collect('payment.paid_at');
 
         $accounts = collect(Account::enabled()->pluck('name', 'id'))
-            ->prepend(trans('accounts.all'), '');
+            ->prepend(trans('general.all_type', ['type' => trans_choice('general.accounts', 2)]), '');
 
         $transfers = array();
 

app/Http/Controllers/Customers/Payments.php

@@ -27,10 +27,10 @@ class Payments extends Controller
         $payment_methods = Modules::getPaymentMethods();
 
         $categories = collect(Category::enabled()->type('income')->pluck('name', 'id'))
-            ->prepend(trans('categories.all'), '');
+            ->prepend(trans('general.all_type', ['type' => trans_choice('general.categories', 2)]), '');
 
         $accounts = collect(Account::enabled()->pluck('name', 'id'))
-            ->prepend(trans('accounts.all'), '');
+            ->prepend(trans('general.all_type', ['type' => trans_choice('general.accounts', 2)]), '');
 
         return view('customers.payments.index', compact('payments', 'payment_methods', 'categories', 'accounts'));
     }

app/Http/Controllers/Items/Items.php

@@ -23,7 +23,8 @@ class Items extends Controller
     {
         $items = Item::with('category')->collect();
 
-        $categories = Category::enabled()->type('item')->pluck('name', 'id')->prepend(trans('categories.all'), '');
+        $categories = Category::enabled()->type('item')->pluck('name', 'id')
+            ->prepend(trans('general.all_type', ['type' => trans_choice('general.categories', 2)]), '');
 
         return view('items.items.index', compact('items', 'categories'));
     }

app/Http/Controllers/Settings/Categories.php

@@ -19,7 +19,7 @@ class Categories extends Controller
         $categories = Category::collect();
 
         $types = collect(['expense' => 'Expense', 'income' => 'Income', 'item' => 'Item', 'other' => 'Other'])
-            ->prepend(trans('categories.all_types'), '');
+            ->prepend(trans('general.all_type', ['type' => trans_choice('general.types', 2)]), '');
 
         return view('settings.categories.index', compact('categories', 'types'));
     }

app/Http/ViewComposers/Modules.php

@@ -23,7 +23,7 @@ class Modules
         if (setting('general.api_token')) {
             $categories = Cache::remember('modules.categories', Date::now()->addHour(6), function () {
                 return collect($this->getCategories())->pluck('name', 'slug')
-                    ->prepend(trans('categories.all'), '');
+                    ->prepend(trans('general.all_type', ['type' => trans_choice('general.categories', 2)]), '');
             });
 
             $view->with(['categories' => $categories]);

resources/lang/en-GB/accounts.php

@@ -10,6 +10,5 @@ return [
     'bank_phone'            => 'Bank Phone',
     'bank_address'          => 'Bank Address',
     'default_account'       => 'Default Account',
-    'all'                   => 'All Accounts',
 
 ];

resources/lang/en-GB/categories.php

@@ -1,7 +0,0 @@
-<?php
-
-return [
-
-    'all'                   => 'All Categories',
-    'all_types'             => 'All Types'
-];

resources/lang/en-GB/roles.php

@@ -1,7 +0,0 @@
-<?php
-
-return [
-
-    'all'                   => 'All Roles',
-
-];

resources/views/customers/invoices/index.blade.php

@@ -16,7 +16,7 @@
         <div class="pull-left">
             <span class="title-filter">{{ trans('general.search') }}:</span>
             {!! Form::text('search', request('search'), ['class' => 'form-control input-filter input-sm', 'placeholder' => trans('general.search_placeholder')]) !!}
-            {!! Form::select('status', $status, request('status'), ['class' => 'form-control input-filter input-sm', 'placeholder' => trans('status.all')]) !!}
+            {!! Form::select('status', $status, request('status'), ['class' => 'form-control input-filter input-sm']) !!}
             {!! Form::button('<span class="fa fa-filter"></span> &nbsp;' . trans('general.filter'), ['type' => 'submit', 'class' => 'btn btn-sm btn-default btn-filter']) !!}
         </div>
         <div class="pull-right">

resources/views/customers/payments/index.blade.php

@@ -16,8 +16,8 @@
         <div class="pull-left">
             <span class="title-filter">{{ trans('general.search') }}:</span>
             {!! Form::text('search', request('search'), ['class' => 'form-control input-filter input-sm', 'placeholder' => trans('general.search_placeholder')]) !!}
-            {!! Form::select('category_id', $categories, request('category_id'), ['class' => 'form-control input-filter input-sm', 'placeholder' => trans('categories.all')]) !!}
+            {!! Form::select('category_id', $categories, request('category_id'), ['class' => 'form-control input-filter input-sm']) !!}
-            {!! Form::select('payment_method', $payment_methods, request('payment_method'), ['class' => 'form-control input-filter input-sm', 'placeholder' => trans_choice('general.payment_methods', 2)]) !!}
+            {!! Form::select('payment_method', $payment_methods, request('payment_method'), ['class' => 'form-control input-filter input-sm']) !!}
             {!! Form::button('<span class="fa fa-filter"></span> &nbsp;' . trans('general.filter'), ['type' => 'submit', 'class' => 'btn btn-sm btn-default btn-filter']) !!}
         </div>
         <div class="pull-right">