shihaam/GitNex
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[Bug] Crash in issues fragment (#444)

Browse Source 
Fixed #443

Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/444
Reviewed-by: 6543 <6543@noreply.gitea.io>
This commit is contained in:
M M Arif 2020-04-23 15:08:53 +00:00 committed by 6543
parent 3ddf978bf0
commit e8c25fca2a
2 changed files with 47 additions and 59 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
app/src/main/java/org/mian/gitnex/fragments/IssuesClosedFragment.java
View File

@ -2,7 +2,6 @@ package org.mian.gitnex.fragments;
import android.content.Context; import android.content.Context;
import android.os.Bundle; import android.os.Bundle;
import android.os.Handler;
import android.util.Log; import android.util.Log;
import android.view.LayoutInflater; import android.view.LayoutInflater;
import android.view.Menu; import android.view.Menu;
@ -207,57 +206,52 @@ public class IssuesClosedFragment extends Fragment implements ItemFilterListener
footerAdapter.clear(); footerAdapter.clear();
//noinspection unchecked //noinspection unchecked
footerAdapter.add(new ProgressItem().withEnabled(false)); footerAdapter.add(new ProgressItem().withEnabled(false));
Handler handler = new Handler();
handler.postDelayed(() -> { Call<List<Issues>> call = RetrofitClient.getInstance(instanceUrl, getContext()).getApiInterface().getClosedIssues(token, repoOwner, repoName, currentPage + 1, issueState, resultLimit, requestType);
Call<List<Issues>> call = RetrofitClient.getInstance(instanceUrl, getContext()).getApiInterface().getClosedIssues(token, repoOwner, repoName, currentPage + 1, issueState, resultLimit, requestType); call.enqueue(new Callback<List<Issues>>() {
call.enqueue(new Callback<List<Issues>>() { @Override
public void onResponse(@NonNull Call<List<Issues>> call, @NonNull Response<List<Issues>> response) {
@Override if(response.isSuccessful()) {
public void onResponse(@NonNull Call<List<Issues>> call, @NonNull Response<List<Issues>> response) {
if(response.isSuccessful()) { assert response.body() != null;
assert response.body() != null; if(response.body().size() > 0) {
if(response.body().size() > 0) { loadNextFlag = response.body().size() == resultLimit;
loadNextFlag = response.body().size() == resultLimit; for(int i = 0; i < response.body().size(); i++) {
for(int i = 0; i < response.body().size(); i++) { fastItemAdapter.add(fastItemAdapter.getAdapterItemCount(), new IssuesAdapter(getContext()).withNewItems(response.body().get(i).getTitle(), response.body().get(i).getNumber(), response.body().get(i).getUser().getAvatar_url(), response.body().get(i).getCreated_at(), response.body().get(i).getComments(), response.body().get(i).getUser().getFull_name(), response.body().get(i).getUser().getLogin()));
fastItemAdapter.add(fastItemAdapter.getAdapterItemCount(), new IssuesAdapter(getContext()).withNewItems(response.body().get(i).getTitle(), response.body().get(i).getNumber(), response.body().get(i).getUser().getAvatar_url(), response.body().get(i).getCreated_at(), response.body().get(i).getComments(), response.body().get(i).getUser().getFull_name(), response.body().get(i).getUser().getLogin()));
}
footerAdapter.clear();
mProgressBarClosed.setVisibility(View.GONE);
} }
else {
footerAdapter.clear();
}
footerAdapter.clear();
mProgressBarClosed.setVisibility(View.GONE); mProgressBarClosed.setVisibility(View.GONE);
} }
else { else {
Log.i(TAG, String.valueOf(response.code())); footerAdapter.clear();
} }
mProgressBarClosed.setVisibility(View.GONE);
}
else {
Log.i(TAG, String.valueOf(response.code()));
} }
@Override }
public void onFailure(@NonNull Call<List<Issues>> call, @NonNull Throwable t) {
Log.i(TAG, t.toString()); @Override
} public void onFailure(@NonNull Call<List<Issues>> call, @NonNull Throwable t) {
}); Log.i(TAG, t.toString());
}
}, 1000); });
if(!loadNextFlag) { if(!loadNextFlag) {
footerAdapter.clear(); footerAdapter.clear();

54
app/src/main/java/org/mian/gitnex/fragments/IssuesOpenFragment.java
View File

@ -11,7 +11,6 @@ import androidx.swiperefreshlayout.widget.SwipeRefreshLayout;
import retrofit2.Call; import retrofit2.Call;
import retrofit2.Callback; import retrofit2.Callback;
import retrofit2.Response; import retrofit2.Response;
import android.os.Handler;
import android.util.Log; import android.util.Log;
import android.view.LayoutInflater; import android.view.LayoutInflater;
import android.view.Menu; import android.view.Menu;
@ -204,57 +203,52 @@ public class IssuesOpenFragment extends Fragment implements ItemFilterListener<I
footerAdapter.clear(); footerAdapter.clear();
//noinspection unchecked //noinspection unchecked
footerAdapter.add(new ProgressItem().withEnabled(false)); footerAdapter.add(new ProgressItem().withEnabled(false));
Handler handler = new Handler();
handler.postDelayed(() -> { Call<List<Issues>> call = RetrofitClient.getInstance(instanceUrl, getContext()).getApiInterface().getIssues(token, repoOwner, repoName, currentPage + 1, resultLimit, requestType);
Call<List<Issues>> call = RetrofitClient.getInstance(instanceUrl, getContext()).getApiInterface().getIssues(token, repoOwner, repoName, currentPage + 1, resultLimit, requestType); call.enqueue(new Callback<List<Issues>>() {
call.enqueue(new Callback<List<Issues>>() { @Override
public void onResponse(@NonNull Call<List<Issues>> call, @NonNull Response<List<Issues>> response) {
@Override if(response.isSuccessful()) {
public void onResponse(@NonNull Call<List<Issues>> call, @NonNull Response<List<Issues>> response) {
if(response.isSuccessful()) { assert response.body() != null;
assert response.body() != null; if(response.body().size() > 0) {
if(response.body().size() > 0) { loadNextFlag = response.body().size() == resultLimit;
loadNextFlag = response.body().size() == resultLimit; for(int i = 0; i < response.body().size(); i++) {
for(int i = 0; i < response.body().size(); i++) { fastItemAdapter.add(fastItemAdapter.getAdapterItemCount(), new IssuesAdapter(getContext()).withNewItems(response.body().get(i).getTitle(), response.body().get(i).getNumber(), response.body().get(i).getUser().getAvatar_url(), response.body().get(i).getCreated_at(), response.body().get(i).getComments(), response.body().get(i).getUser().getFull_name(), response.body().get(i).getUser().getLogin()));
fastItemAdapter.add(fastItemAdapter.getAdapterItemCount(), new IssuesAdapter(getContext()).withNewItems(response.body().get(i).getTitle(), response.body().get(i).getNumber(), response.body().get(i).getUser().getAvatar_url(), response.body().get(i).getCreated_at(), response.body().get(i).getComments(), response.body().get(i).getUser().getFull_name(), response.body().get(i).getUser().getLogin()));
}
footerAdapter.clear();
noDataIssues.setVisibility(View.GONE);
} }
else {
footerAdapter.clear();
}
mProgressBar.setVisibility(View.GONE); footerAdapter.clear();
noDataIssues.setVisibility(View.GONE);
} }
else { else {
Log.i(TAG, String.valueOf(response.code())); footerAdapter.clear();
} }
mProgressBar.setVisibility(View.GONE);
}
else {
Log.i(TAG, String.valueOf(response.code()));
} }
@Override }
public void onFailure(@NonNull Call<List<Issues>> call, @NonNull Throwable t) {
Log.i(TAG, t.toString()); @Override
} public void onFailure(@NonNull Call<List<Issues>> call, @NonNull Throwable t) {
}); Log.i(TAG, t.toString());
}
}, 1000); });
if(!loadNextFlag) { if(!loadNextFlag) {
footerAdapter.clear(); footerAdapter.clear();