From c7c2ac2a1103eea60d5973808bd67a1475d82ade Mon Sep 17 00:00:00 2001 From: M M Arif Date: Wed, 24 Jun 2020 22:29:58 +0200 Subject: [PATCH] Enhance bottomsheets ui (#550) Fix name collision in themes Add space between org and repo name standard use of dimens more ui improvements wip to enhance all bottom sheets Fix radius and improve the ui enhance bottom sheet Co-authored-by: M M Arif Reviewed-by: opyale --- .../adapters/ExploreRepositoriesAdapter.java | 2 +- .../gitnex/adapters/MyReposListAdapter.java | 2 +- .../gitnex/adapters/ReposListAdapter.java | 2 +- .../adapters/RepositoriesByOrgAdapter.java | 2 +- .../adapters/StarredReposListAdapter.java | 2 +- .../res/drawable/bottom_sheet_top_corners.xml | 13 ++++++ .../res/layout/bottom_sheet_admin_users.xml | 10 ++--- .../res/layout/bottom_sheet_file_viewer.xml | 10 ++--- .../layout/bottom_sheet_issue_comments.xml | 14 +++--- .../res/layout/bottom_sheet_issues_filter.xml | 12 ++--- .../layout/bottom_sheet_labels_in_list.xml | 24 ++++++---- .../layout/bottom_sheet_milestones_filter.xml | 12 ++--- .../bottom_sheet_milestones_in_list.xml | 12 ++--- .../res/layout/bottom_sheet_organization.xml | 12 ++--- .../bottom_sheet_organization_teams.xml | 10 ++--- .../main/res/layout/bottom_sheet_profile.xml | 10 ++--- .../bottom_sheet_pull_request_filter.xml | 12 ++--- app/src/main/res/layout/bottom_sheet_repo.xml | 44 +++++++++--------- .../bottom_sheet_repository_in_list.xml | 26 ++++++----- .../res/layout/bottom_sheet_single_issue.xml | 45 +++++++++---------- app/src/main/res/values-v23/themes.xml | 3 +- app/src/main/res/values/themes.xml | 16 ++++++- 22 files changed, 167 insertions(+), 128 deletions(-) create mode 100644 app/src/main/res/drawable/bottom_sheet_top_corners.xml diff --git a/app/src/main/java/org/mian/gitnex/adapters/ExploreRepositoriesAdapter.java b/app/src/main/java/org/mian/gitnex/adapters/ExploreRepositoriesAdapter.java index 87c5103c..c518d5fe 100644 --- a/app/src/main/java/org/mian/gitnex/adapters/ExploreRepositoriesAdapter.java +++ b/app/src/main/java/org/mian/gitnex/adapters/ExploreRepositoriesAdapter.java @@ -153,7 +153,7 @@ public class ExploreRepositoriesAdapter extends RecyclerView.Adapter + + + + + + + + + diff --git a/app/src/main/res/layout/bottom_sheet_admin_users.xml b/app/src/main/res/layout/bottom_sheet_admin_users.xml index d94c217e..cd6356ce 100644 --- a/app/src/main/res/layout/bottom_sheet_admin_users.xml +++ b/app/src/main/res/layout/bottom_sheet_admin_users.xml @@ -4,9 +4,9 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingBottom="8dp" - android:background="?attr/primaryBackgroundColor" - android:paddingTop="8dp"> + android:paddingTop="6dp" + android:paddingBottom="12dp" + android:background="?attr/primaryBackgroundColor"> + android:padding="12dp" /> - \ No newline at end of file + diff --git a/app/src/main/res/layout/bottom_sheet_file_viewer.xml b/app/src/main/res/layout/bottom_sheet_file_viewer.xml index 180ffd3d..107015dd 100644 --- a/app/src/main/res/layout/bottom_sheet_file_viewer.xml +++ b/app/src/main/res/layout/bottom_sheet_file_viewer.xml @@ -4,9 +4,9 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingBottom="8dp" - android:background="?attr/primaryBackgroundColor" - android:paddingTop="8dp"> + android:paddingTop="6dp" + android:paddingBottom="12dp" + android:background="?attr/primaryBackgroundColor"> + android:padding="12dp" /> - \ No newline at end of file + diff --git a/app/src/main/res/layout/bottom_sheet_issue_comments.xml b/app/src/main/res/layout/bottom_sheet_issue_comments.xml index f7b08e75..383ba984 100644 --- a/app/src/main/res/layout/bottom_sheet_issue_comments.xml +++ b/app/src/main/res/layout/bottom_sheet_issue_comments.xml @@ -4,9 +4,9 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingBottom="8dp" - android:background="?attr/primaryBackgroundColor" - android:paddingTop="8dp"> + android:paddingTop="6dp" + android:paddingBottom="12dp" + android:background="?attr/primaryBackgroundColor"> + android:padding="12dp" /> + android:padding="12dp" /> + android:padding="12dp" /> - \ No newline at end of file + diff --git a/app/src/main/res/layout/bottom_sheet_issues_filter.xml b/app/src/main/res/layout/bottom_sheet_issues_filter.xml index 87101f07..1193ba65 100644 --- a/app/src/main/res/layout/bottom_sheet_issues_filter.xml +++ b/app/src/main/res/layout/bottom_sheet_issues_filter.xml @@ -4,9 +4,9 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingBottom="8dp" - android:background="?attr/primaryBackgroundColor" - android:paddingTop="8dp"> + android:paddingTop="6dp" + android:paddingBottom="12dp" + android:background="?attr/primaryBackgroundColor"> + android:padding="12dp" /> + android:padding="12dp" /> - \ No newline at end of file + diff --git a/app/src/main/res/layout/bottom_sheet_labels_in_list.xml b/app/src/main/res/layout/bottom_sheet_labels_in_list.xml index 9527ffad..b94193ee 100644 --- a/app/src/main/res/layout/bottom_sheet_labels_in_list.xml +++ b/app/src/main/res/layout/bottom_sheet_labels_in_list.xml @@ -4,9 +4,9 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingBottom="8dp" - android:background="?attr/primaryBackgroundColor" - android:paddingTop="8dp"> + android:paddingTop="6dp" + android:paddingBottom="12dp" + android:background="?attr/primaryBackgroundColor"> + android:textSize="18sp" /> + + + android:padding="12dp" /> + android:padding="12dp" /> - \ No newline at end of file + diff --git a/app/src/main/res/layout/bottom_sheet_milestones_filter.xml b/app/src/main/res/layout/bottom_sheet_milestones_filter.xml index 13f3784d..6fc48f88 100644 --- a/app/src/main/res/layout/bottom_sheet_milestones_filter.xml +++ b/app/src/main/res/layout/bottom_sheet_milestones_filter.xml @@ -4,9 +4,9 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingBottom="8dp" - android:background="?attr/primaryBackgroundColor" - android:paddingTop="8dp"> + android:paddingTop="6dp" + android:paddingBottom="12dp" + android:background="?attr/primaryBackgroundColor"> + android:padding="12dp" /> + android:padding="12dp" /> - \ No newline at end of file + diff --git a/app/src/main/res/layout/bottom_sheet_milestones_in_list.xml b/app/src/main/res/layout/bottom_sheet_milestones_in_list.xml index e28f62ea..8ca9d814 100644 --- a/app/src/main/res/layout/bottom_sheet_milestones_in_list.xml +++ b/app/src/main/res/layout/bottom_sheet_milestones_in_list.xml @@ -4,9 +4,9 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingBottom="8dp" - android:background="?attr/primaryBackgroundColor" - android:paddingTop="8dp"> + android:paddingTop="6dp" + android:paddingBottom="12dp" + android:background="?attr/primaryBackgroundColor"> + android:padding="12dp" /> + android:padding="12dp" /> - \ No newline at end of file + diff --git a/app/src/main/res/layout/bottom_sheet_organization.xml b/app/src/main/res/layout/bottom_sheet_organization.xml index dd97201c..6ef158fe 100644 --- a/app/src/main/res/layout/bottom_sheet_organization.xml +++ b/app/src/main/res/layout/bottom_sheet_organization.xml @@ -4,9 +4,9 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingBottom="8dp" - android:background="?attr/primaryBackgroundColor" - android:paddingTop="8dp"> + android:paddingTop="6dp" + android:paddingBottom="12dp" + android:background="?attr/primaryBackgroundColor"> + android:padding="12dp" /> + android:padding="12dp" /> - \ No newline at end of file + diff --git a/app/src/main/res/layout/bottom_sheet_organization_teams.xml b/app/src/main/res/layout/bottom_sheet_organization_teams.xml index 4887e710..c163cbee 100644 --- a/app/src/main/res/layout/bottom_sheet_organization_teams.xml +++ b/app/src/main/res/layout/bottom_sheet_organization_teams.xml @@ -4,9 +4,9 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingBottom="8dp" - android:background="?attr/primaryBackgroundColor" - android:paddingTop="8dp"> + android:paddingTop="6dp" + android:paddingBottom="12dp" + android:background="?attr/primaryBackgroundColor"> + android:padding="12dp" /> - \ No newline at end of file + diff --git a/app/src/main/res/layout/bottom_sheet_profile.xml b/app/src/main/res/layout/bottom_sheet_profile.xml index 93765da0..92f6d504 100644 --- a/app/src/main/res/layout/bottom_sheet_profile.xml +++ b/app/src/main/res/layout/bottom_sheet_profile.xml @@ -4,9 +4,9 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingBottom="8dp" - android:background="?attr/primaryBackgroundColor" - android:paddingTop="8dp"> + android:paddingTop="6dp" + android:paddingBottom="12dp" + android:background="?attr/primaryBackgroundColor"> + android:padding="12dp" /> - \ No newline at end of file + diff --git a/app/src/main/res/layout/bottom_sheet_pull_request_filter.xml b/app/src/main/res/layout/bottom_sheet_pull_request_filter.xml index b49c6234..d339478d 100644 --- a/app/src/main/res/layout/bottom_sheet_pull_request_filter.xml +++ b/app/src/main/res/layout/bottom_sheet_pull_request_filter.xml @@ -4,9 +4,9 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingBottom="8dp" - android:background="?attr/primaryBackgroundColor" - android:paddingTop="8dp"> + android:paddingTop="6dp" + android:paddingBottom="12dp" + android:background="?attr/primaryBackgroundColor"> + android:padding="12dp" /> + android:padding="12dp" /> - \ No newline at end of file + diff --git a/app/src/main/res/layout/bottom_sheet_repo.xml b/app/src/main/res/layout/bottom_sheet_repo.xml index ec8166e3..70f828a5 100644 --- a/app/src/main/res/layout/bottom_sheet_repo.xml +++ b/app/src/main/res/layout/bottom_sheet_repo.xml @@ -4,9 +4,9 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingBottom="8dp" - android:background="?attr/primaryBackgroundColor" - android:paddingTop="8dp"> + android:paddingTop="6dp" + android:paddingBottom="12dp" + android:background="?attr/primaryBackgroundColor"> + android:padding="12dp" /> + android:padding="12dp" /> + android:padding="12dp" /> + android:padding="12dp" /> + android:padding="12dp" /> @@ -95,7 +95,7 @@ android:drawablePadding="24dp" android:textColor="?attr/primaryTextColor" android:textSize="16sp" - android:padding="16dp" /> + android:padding="12dp" /> + android:padding="12dp" /> + android:padding="12dp" /> + android:padding="12dp" /> + android:padding="12dp" /> @@ -160,10 +160,10 @@ android:layout_gravity="center_vertical" android:drawableStart="@drawable/ic_share_24dp" android:drawablePadding="24dp" - android:padding="16dp" android:text="@string/shareRepository" android:textColor="?attr/primaryTextColor" - android:textSize="16sp" /> + android:textSize="16sp" + android:padding="12dp" /> + android:textSize="16sp" + android:padding="12dp" /> - \ No newline at end of file + diff --git a/app/src/main/res/layout/bottom_sheet_repository_in_list.xml b/app/src/main/res/layout/bottom_sheet_repository_in_list.xml index be1c0d65..3174710d 100644 --- a/app/src/main/res/layout/bottom_sheet_repository_in_list.xml +++ b/app/src/main/res/layout/bottom_sheet_repository_in_list.xml @@ -4,9 +4,9 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingBottom="8dp" - android:background="?attr/primaryBackgroundColor" - android:paddingTop="8dp"> + android:paddingTop="6dp" + android:paddingBottom="12dp" + android:background="?attr/primaryBackgroundColor"> + android:textSize="18sp" /> + + + android:padding="12dp" /> + android:padding="12dp" /> + android:padding="12dp" /> - \ No newline at end of file + diff --git a/app/src/main/res/layout/bottom_sheet_single_issue.xml b/app/src/main/res/layout/bottom_sheet_single_issue.xml index 17257e8d..f3287c6a 100644 --- a/app/src/main/res/layout/bottom_sheet_single_issue.xml +++ b/app/src/main/res/layout/bottom_sheet_single_issue.xml @@ -4,9 +4,9 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingBottom="8dp" - android:background="?attr/primaryBackgroundColor" - android:paddingTop="8dp"> + android:paddingTop="6dp" + android:paddingBottom="12dp" + android:background="?attr/primaryBackgroundColor"> + android:padding="12dp" /> + android:padding="12dp" /> + android:padding="12dp" /> + android:padding="12dp" /> + android:padding="12dp" /> + android:padding="12dp" /> + android:visibility="gone" + android:padding="12dp" /> @@ -119,10 +118,10 @@ android:layout_gravity="center_vertical" android:drawableStart="@drawable/ic_share_24dp" android:drawablePadding="24dp" - android:padding="16dp" android:text="@string/shareIssue" android:textColor="?attr/primaryTextColor" - android:textSize="16sp" /> + android:textSize="16sp" + android:padding="12dp" /> + android:textSize="16sp" + android:padding="12dp" /> @@ -154,7 +153,7 @@ android:drawablePadding="24dp" android:textColor="?attr/primaryTextColor" android:textSize="16sp" - android:padding="16dp" /> + android:padding="12dp" /> + android:visibility="gone" + android:padding="12dp" /> diff --git a/app/src/main/res/values-v23/themes.xml b/app/src/main/res/values-v23/themes.xml index c49d09bc..870d5332 100644 --- a/app/src/main/res/values-v23/themes.xml +++ b/app/src/main/res/values-v23/themes.xml @@ -24,6 +24,7 @@ @color/hintColor @color/darkGreen @color/lightThemeDividerColor + @style/AppThemeLightBottomSheetDialog - \ No newline at end of file + diff --git a/app/src/main/res/values/themes.xml b/app/src/main/res/values/themes.xml index b7597c7c..19fb3766 100644 --- a/app/src/main/res/values/themes.xml +++ b/app/src/main/res/values/themes.xml @@ -24,6 +24,7 @@ @color/hintColor @color/darkGreen @color/dividerColorDark + @style/AppThemeDarkBottomSheetDialog @@ -50,9 +51,22 @@ @color/hintColor @color/darkGreen @color/lightThemeDividerColor + @style/AppThemeLightBottomSheetDialog + + + + + + - \ No newline at end of file +