diff --git a/api/tasks.py b/api/tasks.py index ceffe76..6e56993 100644 --- a/api/tasks.py +++ b/api/tasks.py @@ -19,19 +19,6 @@ OMADA_PROXY_URL = env("OMADA_PROXY_URL", default="") # type: ignore OMADA_SITE_ID = env("OMADA_SITE_ID", default="") # type: ignore OMADA_GROUP_ID = env("OMADA_GROUP_ID", default="") # type: ignore -if not OMADA_SITE_ID: - raise ValueError( - "OMADA_SITE_ID is not set. Please set it in your environment variables." - ) -if not OMADA_GROUP_ID: - raise ValueError( - "OMADA_GROUP_ID is not set. Please set it in your environment variables." - ) -if not OMADA_PROXY_URL: - raise ValueError( - "OMADA_PROXY_URL is not set. Please set it in your environment variables." - ) - @shared_task def add(x, y): @@ -76,6 +63,10 @@ def get_existing_omada_devices(): Get existing Omada devices from the database. :return: List of existing device names. """ + if not OMADA_PROXY_URL: + raise ValueError( + "OMADA_PROXY_URL is not set. Please set it in your environment variables." + ) try: response = requests.get( f"{OMADA_PROXY_URL}/9fd0cffa3475a74ae4e4d37de0d12414/api/v2/sites/66dcddb804aa0d2978cf145f/setting/profiles/groups", @@ -102,6 +93,18 @@ def add_new_devices_to_omada(new_devices: list[dict]): Add new devices to Omada. :param new_devices: List of new device names to add. """ + if not OMADA_SITE_ID: + raise ValueError( + "OMADA_SITE_ID is not set. Please set it in your environment variables." + ) + if not OMADA_GROUP_ID: + raise ValueError( + "OMADA_GROUP_ID is not set. Please set it in your environment variables." + ) + if not OMADA_PROXY_URL: + raise ValueError( + "OMADA_PROXY_URL is not set. Please set it in your environment variables." + ) try: PAYLOAD = { "name": "REGISTERED_DEVICES",