sarlink/sarlink-portal-api
7
0
Fork 0
mirror of https://github.com/i701/sarlink-portal-api.git synced 2025-04-20 05:56:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add device existence check in CreatePaymentView to handle invalid device IDs

Browse Source
This commit is contained in:
i701 2025-04-05 16:10:24 +05:00
parent 43f9b7ef7c
commit d386c7e37c
Signed by: i701
GPG Key ID: 54A0DA1E26D8E587
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
billing/views.py
View File

@ -1,5 +1,6 @@
# Create your views here. # Create your views here.
# billing/views.py # billing/views.py
from django.shortcuts import get_object_or_404
from .models import Payment, Device from .models import Payment, Device
from datetime import datetime, timedelta from datetime import datetime, timedelta
import requests import requests
@ -29,6 +30,13 @@ class CreatePaymentView(StaffEditorPermissionMixin, generics.CreateAPIView):
device_ids = data.get("device_ids", []) device_ids = data.get("device_ids", [])
print(amount, number_of_months, device_ids) print(amount, number_of_months, device_ids)
for device_id in device_ids:
device = get_object_or_404(Device, id=device_id)
if not device:
return Response(
{"message": f"Device with id {device_id} not found."},
status=status.HTTP_400_BAD_REQUEST,
)
if not amount or not number_of_months: if not amount or not number_of_months:
return Response( return Response(
{"message": "amount and number_of_months are required."}, {"message": "amount and number_of_months are required."},