sarlink/sarlink-portal-api
7
0
Fork 0
mirror of https://github.com/i701/sarlink-portal-api.git synced 2025-05-01 02:15:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor payment verification to use PAYMENT_BASE_URL from environment variables and improve error handling for missing configuration
Some checks failed
Build and Push Docker Images / Build and Push Docker Images (push) Failing after 1m31s
Details

Browse Source
This commit is contained in:
i701 2025-04-23 10:03:04 +05:00
parent 2431793886
commit 929c6168a4
2 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.env.example
View File

@ -15,7 +15,7 @@ EMAIL_PORT=
EMAIL_USERNAME= EMAIL_USERNAME=
EMAIL_PASSWORD= EMAIL_PASSWORD=
PAYMENT_VERIFY_BASE_URL="" PAYMENT_BASE_URL=""
FRONTEND_URL="" FRONTEND_URL=""
SMS_API_URL="" SMS_API_URL=""

21
billing/views.py
View File

@ -4,7 +4,7 @@ from datetime import timedelta
from django.utils import timezone from django.utils import timezone
import requests import requests
from decouple import config
from rest_framework import generics, status from rest_framework import generics, status
from rest_framework.response import Response from rest_framework.response import Response
@ -13,6 +13,19 @@ from api.mixins import StaffEditorPermissionMixin
from .models import Device, Payment from .models import Device, Payment
from .serializers import PaymentSerializer, UpdatePaymentSerializer from .serializers import PaymentSerializer, UpdatePaymentSerializer
from apibase.env import env, BASE_DIR
from django.utils.timezone import localtime
import os
env.read_env(os.path.join(BASE_DIR, ".env"))
PAYMENT_BASE_URL = env("PAYMENT_BASE_URL", default=None)
if not PAYMENT_BASE_URL:
raise ValueError(
"PAYMENT_BASE_URL is not set. Please set it in your environment variables."
)
print("PAYMENT_BASE_URL from env:", PAYMENT_BASE_URL)
class InsufficientFundsError(Exception): class InsufficientFundsError(Exception):
pass pass
@ -145,7 +158,7 @@ class VerifyPaymentView(StaffEditorPermissionMixin, generics.UpdateAPIView):
"benefName": f"{user.first_name} {user.last_name}", "benefName": f"{user.first_name} {user.last_name}",
"accountNo": user.acc_no, "accountNo": user.acc_no,
"absAmount": payment.amount, "absAmount": payment.amount,
"time": (timezone.now() + timedelta(minutes=5)).strftime( "time": localtime(timezone.now() + timedelta(minutes=5)).strftime(
"%Y-%m-%d %H:%M" "%Y-%m-%d %H:%M"
), ),
} }
@ -180,9 +193,9 @@ class VerifyPaymentView(StaffEditorPermissionMixin, generics.UpdateAPIView):
return True return True
def verify_transfer_payment(self, data, payment): def verify_transfer_payment(self, data, payment):
print("verifying transfer payment...") print(data)
response = requests.post( response = requests.post(
f"{config('PAYMENT_VERIFY_BASE_URL')}/verify-payment", f"{PAYMENT_BASE_URL}/verify-payment",
json=data, json=data,
headers={"Content-Type": "application/json"}, headers={"Content-Type": "application/json"},
) )