Enhance CreateTemporaryUserView to check for existing users in both TemporaryUser and User models
All checks were successful
Build and Push Docker Images / Build and Push Docker Images (push) Successful in 3m19s

This commit is contained in:
i701 2025-04-17 14:11:46 +05:00
parent 1401c3ac37
commit 88a2b8ead2

View File

@ -103,24 +103,30 @@ class CreateTemporaryUserView(generics.CreateAPIView):
firstname = request.data.get("firstname")
lastname = request.data.get("lastname")
if TemporaryUser.objects.filter(t_mobile=mobile).exists():
if (
TemporaryUser.objects.filter(t_mobile=mobile).exists()
or User.objects.filter(mobile=mobile).exists()
):
return Response({"message": ErrorMessages.MOBILE_EXISTS}, status=400)
if TemporaryUser.objects.filter(t_username=username).exists():
if (
TemporaryUser.objects.filter(t_username=username).exists()
or User.objects.filter(username=username).exists()
):
return Response({"message": ErrorMessages.USERNAME_EXISTS}, status=400)
if TemporaryUser.objects.filter(t_id_card=id_card).exists():
if (
TemporaryUser.objects.filter(t_id_card=id_card).exists()
or User.objects.filter(id_card=id_card).exists()
):
return Response({"message": "ID card already exists."}, status=400)
if (
TemporaryUser.objects.filter(t_id_card=id_card).exists()
or User.objects.filter(id_card=id_card).exists()
):
return Response({"message": ErrorMessages.ID_CARD_EXISTS}, status=400)
if id_card and not re.match(ID_CARD_PATTERN, id_card):
return Response({"message": ErrorMessages.INVALID_ID_CARD}, status=400)
if TemporaryUser.objects.filter(t_id_card=id_card).exists():
return Response({"message": "ID card already exists."}, status=400)
if mobile is None or not re.match(MOBILE_PATTERN, mobile):
return Response({"message": ErrorMessages.INVALID_MOBILE}, status=400)
if acc_no is None or not re.match(ACCOUNT_NUMBER_PATTERN, acc_no):
return Response({"message": ErrorMessages.INVALID_ACCOUNT}, status=400)