Reorganize CPed functions into their original cpp files

src/peds/CivilianPed.cpp

@@ -424,3 +424,45 @@ CCivilianPed::ProcessControl(void)
 	if (m_moved.Magnitude() > 0.0f)
 		Avoid();
 }
+
+// It's "CPhoneInfo::ProcessNearestFreePhone" in PC IDB but that's not true, someone made it up.
+bool
+CPed::RunToReportCrime(eCrimeType crimeToReport)
+{
+#ifdef PEDS_REPORT_CRIMES_ON_PHONE
+	if (bRunningToPhone) {
+		if (!isPhoneAvailable(m_phoneId)) {
+			m_phoneId = -1;
+			bIsRunning = false;
+			ClearSeek(); // clears bRunningToPhone
+			return false;
+		}
+
+		return true;
+	}
+#else
+	// They changed true into false to make this function unusable. So running to phone actually starts but first frame after that cancels it.
+	if (m_nPedState == PED_SEEK_POS)
+		return false;
+#endif
+
+	CVector pos = GetPosition();
+	int phoneId = gPhoneInfo.FindNearestFreePhone(&pos);
+
+	if (phoneId == -1)
+		return false;
+
+	CPhone *phone = &gPhoneInfo.m_aPhones[phoneId];
+#ifndef PEDS_REPORT_CRIMES_ON_PHONE
+	if (phone->m_nState != PHONE_STATE_FREE)
+		return false;
+#endif
+
+	bRunningToPhone = true;
+	SetSeek(phone->m_pEntity->GetMatrix() * -phone->m_pEntity->GetForward(), 1.0f); // original: phone.m_vecPos, 0.3f
+	SetMoveState(PEDMOVE_RUN);
+	bIsRunning = true; // not there in original
+	m_phoneId = phoneId;
+	m_crimeToReportOnPhone = crimeToReport;
+	return true;
+}

src/peds/Ped.h

@@ -5,7 +5,7 @@
 #include "Crime.h"
 #include "EventList.h"
 #include "PedIK.h"
-#include "PedStats.h"
+#include "PedType.h"
 #include "Physical.h"
 #include "Weapon.h"
 #include "WeaponInfo.h"
@@ -13,6 +13,7 @@
 #define FEET_OFFSET	1.04f
 #define CHECK_NEARBY_THINGS_MAX_DIST	15.0f
 #define ENTER_CAR_MAX_DIST	30.0f
+#define CAN_SEE_ENTITY_ANGLE_THRESHOLD	DEGTORAD(60.0f)
 
 struct CPathNode;
 class CAccident;
@@ -568,7 +569,7 @@ public:
 	void CalculateNewOrientation(void);
 	float WorkOutHeadingForMovingFirstPerson(float);
 	void CalculateNewVelocity(void);
-	bool CanSeeEntity(CEntity*, float);
+	bool CanSeeEntity(CEntity*, float threshold = CAN_SEE_ENTITY_ANGLE_THRESHOLD);
 	void RestorePreviousObjective(void);
 	void SetIdle(void);
 #ifdef _MSC_VER
@@ -747,7 +748,7 @@ public:
 	static void PedSetQuickDraggedOutCarPositionCB(CAnimBlendAssociation *assoc, void *arg);
 	static void PedSetDraggedOutCarPositionCB(CAnimBlendAssociation *assoc, void *arg);
 
-	bool IsPlayer(void);
+	bool IsPlayer(void) const;
 	bool UseGroundColModel(void);
 	bool CanSetPedState(void);
 	bool IsPedInControl(void);
@@ -765,7 +766,7 @@ public:
 	void SetStoredObjective(void);
 	void SetLeader(CEntity* leader);
 	void SetPedStats(ePedStats);
-	bool IsGangMember(void);
+	bool IsGangMember(void) const;
 	void Die(void);
 	void EnterTrain(void);
 	void ExitTrain(void);
@@ -788,7 +789,7 @@ public:
 	CObject *SpawnFlyingComponent(int, int8);
 	void SetCarJack_AllClear(CVehicle*, uint32, uint32);
 #ifdef VC_PED_PORTS
-	bool CanPedJumpThis(CEntity*, CVector*);
+	bool CanPedJumpThis(CEntity *unused, CVector *damageNormal = nil);
 #else
 	bool CanPedJumpThis(CEntity*);
 #endif
@@ -809,9 +810,40 @@ public:
 	bool InVehicle(void) { return bInVehicle && m_pMyVehicle; } // True when ped is sitting/standing in vehicle, not in enter/exit state.
 	bool EnteringCar(void) { return m_nPedState == PED_ENTER_CAR || m_nPedState == PED_CARJACK; }
 
-	void ReplaceWeaponWhenExitingVehicle(void);
-	void RemoveWeaponWhenEnteringVehicle(void);
-	bool IsNotInWreckedVehicle();
+	// It was inlined in III but not in VC.
+	inline void
+	ReplaceWeaponWhenExitingVehicle(void)
+	{
+		eWeaponType weaponType = GetWeapon()->m_eWeaponType;
+
+		// If it's Uzi, we may have stored weapon. Uzi is the only gun we can use in car.
+		if (IsPlayer() && weaponType == WEAPONTYPE_UZI) {
+			if (/*IsPlayer() && */ m_storedWeapon != WEAPONTYPE_UNIDENTIFIED) {
+				SetCurrentWeapon(m_storedWeapon);
+				m_storedWeapon = WEAPONTYPE_UNIDENTIFIED;
+			}
+		} else {
+			AddWeaponModel(CWeaponInfo::GetWeaponInfo(weaponType)->m_nModelId);
+		}
+	}
+
+	// It was inlined in III but not in VC.
+	inline void
+	RemoveWeaponWhenEnteringVehicle(void)
+	{
+		if (IsPlayer() && HasWeapon(WEAPONTYPE_UZI) && GetWeapon(WEAPONTYPE_UZI).m_nAmmoTotal > 0) {
+			if (m_storedWeapon == WEAPONTYPE_UNIDENTIFIED)
+				m_storedWeapon = GetWeapon()->m_eWeaponType;
+			SetCurrentWeapon(WEAPONTYPE_UZI);
+		} else {
+			CWeaponInfo *ourWeapon = CWeaponInfo::GetWeaponInfo(GetWeapon()->m_eWeaponType);
+			RemoveWeaponModel(ourWeapon->m_nModelId);
+		}
+	}
+	bool IsNotInWreckedVehicle()
+	{
+		return m_pMyVehicle != nil && ((CEntity*)m_pMyVehicle)->GetStatus() != STATUS_WRECKED;
+	}
 	// My additions, because there were many, many instances of that.
 	inline void SetFindPathAndFlee(CEntity *fleeFrom, int time, bool walk = false)
 	{

src/peds/PedStats.cpp

@@ -1,118 +0,0 @@
-#include "common.h"
-
-#include "General.h"
-#include "FileMgr.h"
-#include "PedStats.h"
-
-CPedStats *CPedStats::ms_apPedStats[NUM_PEDSTATS];
-
-void
-CPedStats::Initialise(void)
-{
-	int i;
-
-	debug("Initialising CPedStats...\n");
-	for(i = 0; i < NUM_PEDSTATS; i++){
-		ms_apPedStats[i] = new CPedStats;
-		ms_apPedStats[i]->m_type = PEDSTAT_PLAYER;
-		ms_apPedStats[i]->m_name[8] = 'R';	// WHAT?
-		ms_apPedStats[i]->m_fleeDistance = 20.0f;
-		ms_apPedStats[i]->m_headingChangeRate = 15.0f;
-		ms_apPedStats[i]->m_fear = 50;
-		ms_apPedStats[i]->m_temper = 50;
-		ms_apPedStats[i]->m_lawfulness = 50;
-		ms_apPedStats[i]->m_sexiness = 50;
-		ms_apPedStats[i]->m_attackStrength = 1.0f;
-		ms_apPedStats[i]->m_defendWeakness = 1.0f;
-		ms_apPedStats[i]->m_flags = 0;
-	}
-	debug("Loading pedstats data...\n");
-	CPedStats::LoadPedStats();
-	debug("CPedStats ready\n");
-}
-
-void
-CPedStats::Shutdown(void)
-{
-	int i;
-	debug("Shutting down CPedStats...\n");
-	for(i = 0; i < NUM_PEDSTATS; i++)
-		delete ms_apPedStats[i];
-	debug("CPedStats shut down\n");
-}
-
-void
-CPedStats::LoadPedStats(void)
-{
-	char *buf;
-	char line[256];
-	char name[32];
-	size_t bp, buflen;
-	int lp, linelen;
-	int type;
-	float fleeDist, headingChangeRate, attackStrength, defendWeakness;
-	int fear, temper, lawfullness, sexiness, flags;
-
-
-	type = 0;
-	buf = new char[16 * 1024];
-
-        CFileMgr::SetDir("DATA");
-        buflen = CFileMgr::LoadFile("PEDSTATS.DAT", (uint8*)buf, 16 * 1024, "r");
-        CFileMgr::SetDir("");
-
-	for(bp = 0; bp < buflen; ){
-		// read file line by line
-		for(linelen = 0; buf[bp] != '\n' && bp < buflen; bp++){
-			if(buf[bp] == '\r' || buf[bp] == ',' || buf[bp] == '\t')
-				line[linelen++] = ' ';
-			else
-				line[linelen++] = buf[bp];
-		}
-		bp++;
-		line[linelen] = '\0';
-
-		// skip white space
-		for(lp = 0; line[lp] <= ' '; lp++);
-
-		if(lp >= linelen ||		// FIX: game uses == here, but this is safer if we have empty lines
-		   line[lp] == '#')
-			continue;
-
-		sscanf(&line[lp], "%s %f %f %d %d %d %d %f %f %d",
-			name,
-			&fleeDist,
-			&headingChangeRate,
-			&fear,
-			&temper,
-			&lawfullness,
-			&sexiness,
-			&attackStrength,
-			&defendWeakness,
-			&flags);
-		ms_apPedStats[type]->m_type = (ePedStats)type;
-		strncpy(ms_apPedStats[type]->m_name, name, 24);	// FIX: game uses strcpy
-		ms_apPedStats[type]->m_fleeDistance = fleeDist;
-		ms_apPedStats[type]->m_headingChangeRate = headingChangeRate;
-		ms_apPedStats[type]->m_fear = fear;
-		ms_apPedStats[type]->m_temper = temper;
-		ms_apPedStats[type]->m_lawfulness = lawfullness;
-		ms_apPedStats[type]->m_sexiness = sexiness;
-		ms_apPedStats[type]->m_attackStrength = attackStrength;
-		ms_apPedStats[type]->m_defendWeakness = defendWeakness;
-		ms_apPedStats[type]->m_flags = flags;
-		type++;
-	}
-
-	delete[] buf;
-}
-
-ePedStats
-CPedStats::GetPedStatType(char *name)
-{
-	for(uint16 type = 0; type < NUM_PEDSTATS; type++)
-		if(!CGeneral::faststrcmp(ms_apPedStats[type]->m_name, name))
-			return (ePedStats) type;
-
-	return NUM_PEDSTATS;
-}

src/peds/PedStats.h

@@ -1,80 +0,0 @@
-#pragma once
-
-enum ePedStats
-{
-	PEDSTAT_PLAYER,
-	PEDSTAT_COP,
-	PEDSTAT_MEDIC,
-	PEDSTAT_FIREMAN,
-	PEDSTAT_GANG1,
-	PEDSTAT_GANG2,
-	PEDSTAT_GANG3,
-	PEDSTAT_GANG4,
-	PEDSTAT_GANG5,
-	PEDSTAT_GANG6,
-	PEDSTAT_GANG7,
-	PEDSTAT_STREET_GUY,
-	PEDSTAT_SUIT_GUY,
-	PEDSTAT_SENSIBLE_GUY,
-	PEDSTAT_GEEK_GUY,
-	PEDSTAT_OLD_GUY,
-	PEDSTAT_TOUGH_GUY,
-	PEDSTAT_STREET_GIRL,
-	PEDSTAT_SUIT_GIRL,
-	PEDSTAT_SENSIBLE_GIRL,
-	PEDSTAT_GEEK_GIRL,
-	PEDSTAT_OLD_GIRL,
-	PEDSTAT_TOUGH_GIRL,
-	PEDSTAT_TRAMP_MALE,
-	PEDSTAT_TRAMP_FEMALE,
-	PEDSTAT_TOURIST,
-	PEDSTAT_PROSTITUTE,
-	PEDSTAT_CRIMINAL,
-	PEDSTAT_BUSKER,
-	PEDSTAT_TAXIDRIVER,
-	PEDSTAT_PSYCHO,
-	PEDSTAT_STEWARD,
-	PEDSTAT_SPORTSFAN,
-	PEDSTAT_SHOPPER,
-	PEDSTAT_OLDSHOPPER,
-
-	NUM_PEDSTATS
-};
-
-// flags
-enum
-{
-	STAT_PUNCH_ONLY = 1,
-	STAT_CAN_KNEE_HEAD = 2,
-	STAT_CAN_KICK = 4,
-	STAT_CAN_ROUNDHOUSE = 8,
-	STAT_NO_DIVE = 0x10,
-	STAT_ONE_HIT_KNOCKDOWN = 0x20,
-	STAT_SHOPPING_BAGS = 0x40,
-	STAT_GUN_PANIC = 0x80
-};
-
-class CPedStats
-{
-public:
-	ePedStats m_type;
-	char m_name[24];
-	float m_fleeDistance;
-	float m_headingChangeRate;
-	int8 m_fear;
-	int8 m_temper;
-	int8 m_lawfulness;
-	int8 m_sexiness;
-	float m_attackStrength;
-	float m_defendWeakness;
-	int16 m_flags;
-
-	static CPedStats *ms_apPedStats[NUM_PEDSTATS];
-
-	static void Initialise(void);
-	static void Shutdown(void);
-	static void LoadPedStats(void);
-	static ePedStats GetPedStatType(char *name);
-};
-
-VALIDATE_SIZE(CPedStats, 0x34);

src/peds/PedType.cpp

@@ -1,9 +1,11 @@
 #include "common.h"
 
+#include "General.h"
 #include "FileMgr.h"
 #include "PedType.h"
 
 CPedType *CPedType::ms_apPedType[NUM_PEDTYPES];
+CPedStats *CPedStats::ms_apPedStats[NUM_PEDSTATS];
 
 void
 CPedType::Initialise(void)
@@ -202,3 +204,114 @@ INITSAVEBUF
 		*ms_apPedType[i] = ReadSaveBuf<CPedType>(buf);
 VALIDATESAVEBUF(size)
 }
+
+void
+CPedStats::Initialise(void)
+{
+	int i;
+
+	debug("Initialising CPedStats...\n");
+	for(i = 0; i < NUM_PEDSTATS; i++){
+		ms_apPedStats[i] = new CPedStats;
+		ms_apPedStats[i]->m_type = PEDSTAT_PLAYER;
+		ms_apPedStats[i]->m_name[8] = 'R';	// WHAT?
+		ms_apPedStats[i]->m_fleeDistance = 20.0f;
+		ms_apPedStats[i]->m_headingChangeRate = 15.0f;
+		ms_apPedStats[i]->m_fear = 50;
+		ms_apPedStats[i]->m_temper = 50;
+		ms_apPedStats[i]->m_lawfulness = 50;
+		ms_apPedStats[i]->m_sexiness = 50;
+		ms_apPedStats[i]->m_attackStrength = 1.0f;
+		ms_apPedStats[i]->m_defendWeakness = 1.0f;
+		ms_apPedStats[i]->m_flags = 0;
+	}
+	debug("Loading pedstats data...\n");
+	CPedStats::LoadPedStats();
+	debug("CPedStats ready\n");
+}
+
+void
+CPedStats::Shutdown(void)
+{
+	int i;
+	debug("Shutting down CPedStats...\n");
+	for(i = 0; i < NUM_PEDSTATS; i++)
+		delete ms_apPedStats[i];
+	debug("CPedStats shut down\n");
+}
+
+void
+CPedStats::LoadPedStats(void)
+{
+	char *buf;
+	char line[256];
+	char name[32];
+	size_t bp, buflen;
+	int lp, linelen;
+	int type;
+	float fleeDist, headingChangeRate, attackStrength, defendWeakness;
+	int fear, temper, lawfullness, sexiness, flags;
+
+
+	type = 0;
+	buf = new char[16 * 1024];
+
+        CFileMgr::SetDir("DATA");
+        buflen = CFileMgr::LoadFile("PEDSTATS.DAT", (uint8*)buf, 16 * 1024, "r");
+        CFileMgr::SetDir("");
+
+	for(bp = 0; bp < buflen; ){
+		// read file line by line
+		for(linelen = 0; buf[bp] != '\n' && bp < buflen; bp++){
+			if(buf[bp] == '\r' || buf[bp] == ',' || buf[bp] == '\t')
+				line[linelen++] = ' ';
+			else
+				line[linelen++] = buf[bp];
+		}
+		bp++;
+		line[linelen] = '\0';
+
+		// skip white space
+		for(lp = 0; line[lp] <= ' '; lp++);
+
+		if(lp >= linelen ||		// FIX: game uses == here, but this is safer if we have empty lines
+		   line[lp] == '#')
+			continue;
+
+		sscanf(&line[lp], "%s %f %f %d %d %d %d %f %f %d",
+			name,
+			&fleeDist,
+			&headingChangeRate,
+			&fear,
+			&temper,
+			&lawfullness,
+			&sexiness,
+			&attackStrength,
+			&defendWeakness,
+			&flags);
+		ms_apPedStats[type]->m_type = (ePedStats)type;
+		strncpy(ms_apPedStats[type]->m_name, name, 24);	// FIX: game uses strcpy
+		ms_apPedStats[type]->m_fleeDistance = fleeDist;
+		ms_apPedStats[type]->m_headingChangeRate = headingChangeRate;
+		ms_apPedStats[type]->m_fear = fear;
+		ms_apPedStats[type]->m_temper = temper;
+		ms_apPedStats[type]->m_lawfulness = lawfullness;
+		ms_apPedStats[type]->m_sexiness = sexiness;
+		ms_apPedStats[type]->m_attackStrength = attackStrength;
+		ms_apPedStats[type]->m_defendWeakness = defendWeakness;
+		ms_apPedStats[type]->m_flags = flags;
+		type++;
+	}
+
+	delete[] buf;
+}
+
+ePedStats
+CPedStats::GetPedStatType(char *name)
+{
+	for(uint16 type = 0; type < NUM_PEDSTATS; type++)
+		if(!CGeneral::faststrcmp(ms_apPedStats[type]->m_name, name))
+			return (ePedStats) type;
+
+	return NUM_PEDSTATS;
+}

src/peds/PedType.h

@@ -92,3 +92,82 @@ public:
 };
 
 VALIDATE_SIZE(CPedType, 0x20);
+
+enum ePedStats
+{
+	PEDSTAT_PLAYER,
+	PEDSTAT_COP,
+	PEDSTAT_MEDIC,
+	PEDSTAT_FIREMAN,
+	PEDSTAT_GANG1,
+	PEDSTAT_GANG2,
+	PEDSTAT_GANG3,
+	PEDSTAT_GANG4,
+	PEDSTAT_GANG5,
+	PEDSTAT_GANG6,
+	PEDSTAT_GANG7,
+	PEDSTAT_STREET_GUY,
+	PEDSTAT_SUIT_GUY,
+	PEDSTAT_SENSIBLE_GUY,
+	PEDSTAT_GEEK_GUY,
+	PEDSTAT_OLD_GUY,
+	PEDSTAT_TOUGH_GUY,
+	PEDSTAT_STREET_GIRL,
+	PEDSTAT_SUIT_GIRL,
+	PEDSTAT_SENSIBLE_GIRL,
+	PEDSTAT_GEEK_GIRL,
+	PEDSTAT_OLD_GIRL,
+	PEDSTAT_TOUGH_GIRL,
+	PEDSTAT_TRAMP_MALE,
+	PEDSTAT_TRAMP_FEMALE,
+	PEDSTAT_TOURIST,
+	PEDSTAT_PROSTITUTE,
+	PEDSTAT_CRIMINAL,
+	PEDSTAT_BUSKER,
+	PEDSTAT_TAXIDRIVER,
+	PEDSTAT_PSYCHO,
+	PEDSTAT_STEWARD,
+	PEDSTAT_SPORTSFAN,
+	PEDSTAT_SHOPPER,
+	PEDSTAT_OLDSHOPPER,
+
+	NUM_PEDSTATS
+};
+
+// flags
+enum
+{
+	STAT_PUNCH_ONLY = 1,
+	STAT_CAN_KNEE_HEAD = 2,
+	STAT_CAN_KICK = 4,
+	STAT_CAN_ROUNDHOUSE = 8,
+	STAT_NO_DIVE = 0x10,
+	STAT_ONE_HIT_KNOCKDOWN = 0x20,
+	STAT_SHOPPING_BAGS = 0x40,
+	STAT_GUN_PANIC = 0x80
+};
+
+class CPedStats
+{
+public:
+	ePedStats m_type;
+	char m_name[24];
+	float m_fleeDistance;
+	float m_headingChangeRate;
+	int8 m_fear;
+	int8 m_temper;
+	int8 m_lawfulness;
+	int8 m_sexiness;
+	float m_attackStrength;
+	float m_defendWeakness;
+	int16 m_flags;
+
+	static CPedStats *ms_apPedStats[NUM_PEDSTATS];
+
+	static void Initialise(void);
+	static void Shutdown(void);
+	static void LoadPedStats(void);
+	static ePedStats GetPedStatType(char *name);
+};
+
+VALIDATE_SIZE(CPedStats, 0x34);